Revert to more exhaustive address scanning #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4b5904 ("Improve syncing/detection during login") changed address scanning to strictly allow an address gap of at most ACCOUNT_MAX_ALLOWED_ADDRESS_GAP, while the implementation we are reverting to is less restrictive by always checking full chunks of size ACCOUNT_MAX_ALLOWED_ADDRESS_GAP, which can result in address gaps between ACCOUNT_MAX_ALLOWED_ADDRESS_GAP and 2*ACCOUNT_MAX_ALLOWED_ADDRESS_GAP-1. This allows to potentially find more of the user's addresses. The more exhaustive scanning is no problem anymore now with the recent perfomance improvements of @nimiq/core. The more detailed status messsages in LoginSuccess of f4b5904 have not been reverted as the only remaining change. The addition of a skip button has already been reverted previously in 1424f5f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f4b5904f("Improve syncing/detection during login") changed address scanning to strictly allow an address gap of at mostACCOUNT_MAX_ALLOWED_ADDRESS_GAP. Now that the more exhaustive scanning is no problem anymore with the recent performance improvements of@nimiq/core, we can revert this to the old implementation which is less restrictive by always checking full chunks of sizeACCOUNT_MAX_ALLOWED_ADDRESS_GAP, which can result in address gaps betweenACCOUNT_MAX_ALLOWED_ADDRESS_GAPand2*ACCOUNT_MAX_ALLOWED_ADDRESS_GAP-1. This allows to potentially find more of the user's addresses.Reverting the commit also fixes the lint error for overlong lines, that #554 intended to fix.
The more detailed status messages in
LoginSuccessoff4b5904fhave not been reverted as the only remaining change of that commit.However, all that being said, we could also consider increasing
ACCOUNT_MAX_ALLOWED_ADDRESS_GAPinstead, to more consistently increase the search range.