-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Added github action to lint code on pull request #122
base: main
Are you sure you want to change the base?
Conversation
f4138d4
to
e9aa33a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor recommended changes, thanks very much for having a look at this one! ❤️
Adding to the above @neozenith, thoughts on this PR also including a run of eslint across the code base? I know lint PRs generally cause a lot of noise, but it'll be a pain we introduce on this PR, or the next person to raise PR against the repo once the check is in place edit; I'm also happy to author that change-set if we want to keep it seperate |
Co-authored-by: Jay Rovacsek <[email protected]>
Co-authored-by: Jay Rovacsek <[email protected]>
run: npm i node @latest | ||
|
||
- name: run lint | ||
uses: wearerequired/lint-action@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nifty GH Action
https://github.com/wearerequired/lint-action
@JayRovacsek sounds good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
I added some basic linting using eslint through a GitHub action (not smoke tested, meme below may be relevant)
Me when this pr gets accepted (maybe)
Solves Issue
#90