-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I/O support for the ndx-pose NWB extension: take 2 #360
Draft
niksirbi
wants to merge
52
commits into
main
Choose a base branch
from
ns-nwb-io
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
- Coverage 99.79% 98.76% -1.04%
==========================================
Files 14 15 +1
Lines 969 1049 +80
==========================================
+ Hits 967 1036 +69
- Misses 2 13 +11 ☔ View full report in Codecov by Sentry. |
9 tasks
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Niko Sirmpilatze <[email protected]>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
This PR is the continuation of #166, building on @edeno's hard work over there. See that PR for more information.
What does this PR do?
Adds a new I/O module, that handles conversions between
ndx-pose
andmovement
poses datasets.References
Closes #23
How has this PR been tested?
TBD...
Is this a breaking change?
Probably not...
Does this PR require an update to the documentation?
Yes, supported formats need to be updated.
Checklist: