Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I/O support for the ndx-pose NWB extension: take 2 #360

Draft
wants to merge 52 commits into
base: main
Choose a base branch
from
Draft

Conversation

niksirbi
Copy link
Member

@niksirbi niksirbi commented Dec 9, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

This PR is the continuation of #166, building on @edeno's hard work over there. See that PR for more information.

What does this PR do?

Adds a new I/O module, that handles conversions between ndx-pose and movement poses datasets.

References

Closes #23

How has this PR been tested?

TBD...

Is this a breaking change?

Probably not...

Does this PR require an update to the documentation?

Yes, supported formats need to be updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 86.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 98.76%. Comparing base (aac61b0) to head (b9305e4).

Files with missing lines Patch % Lines
movement/io/_nwb.py 83.33% 7 Missing ⚠️
movement/io/load_poses.py 89.28% 3 Missing ⚠️
movement/io/save_poses.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   99.79%   98.76%   -1.04%     
==========================================
  Files          14       15       +1     
  Lines         969     1049      +80     
==========================================
+ Hits          967     1036      +69     
- Misses          2       13      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I/O support for the ndx-pose NWB extension
2 participants