Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema definition for federation 2 @link in schema-first #3112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

burn2delete
Copy link

@burn2delete burn2delete commented Dec 21, 2023

Update graphql-federation-definitions.factory.ts

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

schema definition and use of @link is not included in the SDL for the schema in schema-first approach

Issue Number: N/A

What is the new behavior?

schema definition and use of @link is properly included in the SDL for the subgraph

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@burn2delete burn2delete force-pushed the schema-first-fed2-link-fix branch from a3d9842 to 9ee939f Compare December 21, 2023 23:31
@burn2delete burn2delete changed the title Fix federation 2 @link in schema-first Fix schema definition for federation 2 @link in schema-first Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant