Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manylinux image to 2_28 #81

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Jul 2, 2024

Update the manylinux image from the default manylinux2014 to manylinux_2_28.
The former image reached its EOL a few days ago (which also caused the temporary build failures).

Even though cibuildwheel doesn't plan to update the default anytime soon (see pypa/cibuildwheel#1772 (comment)) we could already start to use the 2_28 image. During the Repair wheel step it will get promoted to still support 2_17 / 2014.

With the new image, it's also slightly faster to build.

https://github.com/mayeut/pep600_compliance?tab=readme-ov-file#acceptable-distros-to-build-wheels
https://mayeut.github.io/manylinux-timeline/

/CC @hauntsaninja What do you think?

@cdce8p
Copy link
Contributor Author

cdce8p commented Jul 2, 2024

Repairing wheel...
  
      + sh -c 'auditwheel repair -w /tmp/cibuildwheel/repaired_wheel /tmp/cibuildwheel/built_wheel/mypy-1.11.0+dev.d1d3c780c7a2d30b2a038903289ea7487303a218-cp312-cp312-linux_x86_64.whl'
  INFO:auditwheel.main_repair:Repairing mypy-1.11.0+dev.d1d3c780c7a2d30b2a038903289ea7487303a218-cp312-cp312-linux_x86_64.whl
  INFO:auditwheel.main_repair:Wheel is eligible for a higher priority tag. You requested manylinux_2_28_x86_64 but I have found this wheel is eligible for manylinux_2_17_x86_64.
  INFO:auditwheel.wheeltools:Previous filename tags: linux_x86_64
  INFO:auditwheel.wheeltools:New filename tags: manylinux_2_17_x86_64, manylinux2014_x86_64, manylinux_2_28_x86_64
  INFO:auditwheel.wheeltools:Previous WHEEL info tags: cp312-cp312-linux_x86_64
  INFO:auditwheel.wheeltools:New WHEEL info tags: cp312-cp312-manylinux_2_17_x86_64, cp312-cp312-manylinux2014_x86_64, cp312-cp312-manylinux_2_28_x86_64
  INFO:auditwheel.main_repair:
  Fixed-up wheel written to /tmp/cibuildwheel/repaired_wheel/mypy-1.11.0+dev.d1d3c780c7a2d30b2a038903289ea7487303a218-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_28_x86_64.whl

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, if auditwheel repair is doing something magical this seems fine. The manylinux timeline thing you linked indicates 2.26 would be a very reasonable minimum

@hauntsaninja hauntsaninja merged commit 348f214 into mypyc:master Jul 2, 2024
28 checks passed
@cdce8p cdce8p deleted the update-manylinux-image branch July 2, 2024 20:44
@cdce8p
Copy link
Contributor Author

cdce8p commented Jul 2, 2024

2_24 isn't supported anymore. It was broken to begin with unfortunately. 2_28 is the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants