FIX(client): Permission for settings.json and backup was too open #6667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes permission for settings.json and corresponding backup file to 600. Fixes mumble-voip#6652
Krzmbrzl
reviewed
Dec 15, 2024
There was a problem hiding this comment.
Is there no way to set the permissions directly when writing the file?
If we're young this in a 2-step process, then there always is a short period of time in which the file still has the wrong permissions. Admittedly, that period is very short but ideally we wouldn't have that at all 👀
|
I believe we should set the default permissions on the folder itself, perhaps with a warning when we detect sensitive files to be too accessible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes permission for settings.json and corresponding backup file to 600.
Fixes #6652
Checks