Skip to content
This repository has been archived by the owner on Nov 7, 2020. It is now read-only.

cleanup on 83c0f41e4c, startup performance regression #465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup on 83c0f41e4c, startup performance regression #465

wants to merge 1 commit into from

Conversation

thehunmonkgroup
Copy link
Contributor

this cleanup uses standard backbone architecture to avoid sorting
prior to all collections being loaded. i've included a note for
future developers about the issue, and added some defensive coding
for all other collections being loaded, to prevent similar issues
in the future.

for testing, i added a console log to the user comparator, and this
log output shows it's not called until after all collections are loaded:

info:    redis ready
info:    redis-sync initialized
info:    loading user/*
info:    loading event/?????
info:    loading event/*/hoa/*
warn:    No redis data for event/*/hoa/*
info:    loading event/*/sessions/*
info:    loading session/permalink/*
warn:    No redis data for session/permalink/*
info:    Done loading models.
HIT COMPARATOR
HIT COMPARATOR
HIT COMPARATOR
HIT COMPARATOR
HIT COMPARATOR
HIT COMPARATOR

this cleanup uses standard backbone architecture to avoid sorting
prior to all collections being loaded. i've included a note for
future developers about the issue, added some defensive coding
for all other collections being loaded, to prevent similar issues
in the future.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant