This repository has been archived by the owner on Nov 7, 2020. It is now read-only.
add request destination handling for identity login button. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the requestDestination parameter to all views, which is a special querystring parameter than can be appended for redirect destination handling. The current implementation leverages the existing destination storage in the user session related to google auth flow. the _destination parameter is included in the login link in the _identity view, thus enabling users to be redirected to the same page they were on after logging in. while ensureAuthenticated() handles the auth-required case, this handles the anonymous user case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the requestDestination parameter to all views, which is
a special querystring parameter than can be appended for redirect
destination handling.
The current implementation leverages the existing destination storage
in the user session related to google auth flow. the _destination
parameter is included in the login link in the _identity view, thus
enabling users to be redirected to the same page they were on after
logging in. while ensureAuthenticated() handles the auth-required
case, this handles the anonymous user case.