Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA-A3459 - Add user creation/update/removal management commands #67

Merged
merged 8 commits into from
Dec 18, 2024
Merged

LGA-A3459 - Add user creation/update/removal management commands #67

merged 8 commits into from
Dec 18, 2024

Conversation

said-moj
Copy link
Contributor

@said-moj said-moj commented Dec 9, 2024 •
edited
Loading

What does this pull request do?

Add user creation/update/removal management commands.

Any other changes that would benefit highlighting?

Added the tabulate package to print tables when listing models in management commands

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@said-moj said-moj changed the title LGA-A3459 - dd user creation/update/removal management commands LGA-A3459 - Add user creation/update/removal management commands Dec 9, 2024
@said-moj said-moj force-pushed the feature/LGA-3459-add-users-management-command branch from 05a5c04 to 34b2b7d Compare December 11, 2024 09:16
TawneeOwl
TawneeOwl approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!!!

digitalali-moj
digitalali-moj approved these changes Dec 11, 2024
View reviewed changes
Copy link

@digitalali-moj digitalali-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks - few questions to consider

docs/source/documentation/user-management.erb Outdated Show resolved Hide resolved
manage.py Outdated Show resolved Hide resolved
manage.py Show resolved Hide resolved
manage.py Show resolved Hide resolved
@said-moj said-moj force-pushed the feature/LGA-3459-add-users-management-command branch from 49ddb73 to 802c77a Compare December 16, 2024 13:33
TawneeOwl
TawneeOwl approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BenMillar-MOJ
BenMillar-MOJ requested changes Dec 18, 2024
View reviewed changes
docs/source/documentation/user-management.erb Outdated Show resolved Hide resolved
docs/source/documentation/user-management.erb Outdated Show resolved Hide resolved
docs/source/documentation/user-management.erb Outdated Show resolved Hide resolved
docs/source/documentation/user-management.erb Outdated Show resolved Hide resolved
docs/source/documentation/user-management.erb Outdated Show resolved Hide resolved
BenMillar-MOJ
BenMillar-MOJ approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@BenMillar-MOJ BenMillar-MOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@said-moj said-moj merged commit f56d142 into main Dec 18, 2024
13 of 14 checks passed
@said-moj said-moj deleted the feature/LGA-3459-add-users-management-command branch December 18, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenMillar-MOJ BenMillar-MOJ BenMillar-MOJ approved these changes

@TawneeOwl TawneeOwl TawneeOwl approved these changes

@digitalali-moj digitalali-moj Awaiting requested review from digitalali-moj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@said-moj @digitalali-moj @TawneeOwl @BenMillar-MOJ