Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruletype for Renovate GitHub Action #228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

eleftherias
Copy link
Contributor

No description provided.

@eleftherias eleftherias requested a review from a team as a code owner December 17, 2024 15:40
@rdimitrov
Copy link
Member

What do you think about making this more generic?

Instead of having several ruletypes for each action we want to check against, I'd propose to have a generic one extended by a parameter through which you can specify the action.

Perhaps we can even repurpose the license ruletype into this new ruletype. Currently it allows you to specify a file path and check if a given content is there. Extending it to support a directory of files should be enough to cover the above use case and much more.

@JAORMX
Copy link
Contributor

JAORMX commented Dec 17, 2024

wow! I had no idea that Renovate had a github action. Normally, folks install the Renovate App, and then install a configuration file in the repo: https://docs.renovatebot.com/config-overview/ https://docs.renovatebot.com/configuration-options/

Perhaps we can have yet another rule for this 😄

@mesembria
Copy link

What do you think about making this more generic?

Instead of having several ruletypes for each action we want to check against, I'd propose to have a generic one extended by a parameter through which you can specify the action.

Perhaps we can even repurpose the license ruletype into this new ruletype. Currently it allows you to specify a file path and check if a given content is there. Extending it to support a directory of files should be enough to cover the above use case and much more.

I think that's a good idea for a quick, first pass of a rule to check for GitHub actions. But if you wanted to enhance the rule, or make it more specific, the generic approach might have limitations. For example, with this Renovate rule we also discussed checking for the required config file and checking the schedule as a next step.

@rdimitrov
Copy link
Member

rdimitrov commented Dec 18, 2024

My concern for raising this is this may lead us to the same situation we are with the existing Dependabot ruletype. At the same time I see that having more examples of rules like that could help us understand how a generic one might look like and would it be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants