Rename osi DS -> spdx-license-list #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames the "osi" license list to reference the source. Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
rdimitrov
approved these changes
Dec 12, 2024
blkt
reviewed
Dec 12, 2024
| @@ -1,6 +1,6 @@ | |||
| version: v1 | |||
| type: data-source | |||
| name: osi | |||
There was a problem hiding this comment.
I would name it just spdx, as we might add more functions to it.
This is not as trivial as it might seem, since changing this name is a breaking change because rules use the data source name as namespace for its functions. The name should not reflect the functions, but the data source itself.
There was a problem hiding this comment.
I agree with this, let's take @blkt 's recommendation
JAORMX
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the "osi" license list to reference the source of the license data.
/cc @blkt @rdimitrov
Signed-off-by: Adolfo García Veytia (puerco) [email protected]