Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Miller.Miller to 6.12.0 (#136590) #144939

Conversation

rursprung
Copy link
Contributor

@rursprung rursprung commented Mar 17, 2024

the manifest has been created using the following command:

wingetcreate update miller.miller -v 6.12.0 -u https://github.com/johnkerl/miller/releases/download/v6.12.0/miller-6.12.0-windows-386.zip https://github.com/johnkerl/miller/releases/download/v6.12.0/miller-6.12.0-windows-amd64.zip

the ReleaseNotesUrl has been manually added as wingetcreate update does not yet support release notes (see also
microsoft/winget-create#497).

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

the manifest has been created using the following command:
```bash
wingetcreate update miller.miller -v 6.12.0 -u https://github.com/johnkerl/miller/releases/download/v6.12.0/miller-6.12.0-windows-386.zip https://github.com/johnkerl/miller/releases/download/v6.12.0/miller-6.12.0-windows-amd64.zip
```

the `ReleaseNotesUrl` has been manually added as `wingetcreate update`
does not yet support release notes (see also
microsoft/winget-create#497).
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rursprung
Copy link
Contributor Author

@johnkerl: it'd be great if johnkerl/miller#1459 could be implemented so that this were automated (it should be fairly easy to set up, but it's something you have to do yourself due to the required access token in the workflow). thanks!

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Mar 17, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\mlr.exe returned exit code: 1
Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\mlr.exe returned exit code: 1

(Automated response - build 870.)

@rursprung
Copy link
Contributor Author

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\mlr.exe returned exit code: 1
Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\mlr.exe returned exit code: 1

(Automated response - build 870.)

this is to be expected if mlr is being called w/o any arguments and not a packaging problem.

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Executable-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Mar 18, 2024
@stephengillie
Copy link
Collaborator

this is to be expected if mlr is being called w/o any arguments and not a packaging problem.

This situation is common. Thanks for your patience.

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) March 18, 2024 20:50
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 0752219 into microsoft:master Mar 18, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 18, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@rursprung rursprung deleted the update-miller-to-6.12.0 branch March 19, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants