Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution points #5341

Closed
wants to merge 3 commits into from

Conversation

joey2031
Copy link
Contributor

@joey2031 joey2031 commented May 14, 2022

For issue #5230. I added the missing points but was not sure where to get the links from, so I followed the "pattern" I saw with the other points. Please let me know if there is anything that I did wrong or need to fix. This is my first PR on this project. Excited to hear back. Thank you.

joey2031 added 3 commits May 14, 2022 18:08
Pasted authentication twice by mistake, fixed it.
@gregvanl gregvanl added extensibility extension author content under /api labels May 16, 2022
@gregvanl
Copy link

Hi @joey2031 Thanks for submitting a PR and your interest in the VS Code documentation.
The full vscode-docs issue fix is to add the missing sections to the contribution points documentation.

@joey2031
Copy link
Contributor Author

joey2031 commented May 16, 2022

Hi @joey2031 Thanks for submitting a PR and your interest in the VS Code documentation. The full vscode-docs issue fix is to add the missing sections to the contribution points documentation.

Oh I see. Where can I find the content for the missing sections to add? Or do I need to write something myself? Also if you think there might be better task for a first time contributor please let me know. I'm happy to contribute any way I can :)

@gregvanl
Copy link

Hi @joey2031 If you haven't built and published a VS Code extension, I wouldn't recommend starting out updating the API extension topics.
If you want to research and put together a user guide section, you could work on #3947. This issue is asking for a section on using the Search Editor feature. That would be a good first time contributor issue and you would learn about the cool Search Editor.
I'll close this PR for now.

@gregvanl gregvanl closed this May 16, 2022
@joey2031
Copy link
Contributor Author

Hi @joey2031 If you haven't built and published a VS Code extension, I wouldn't recommend starting out updating the API extension topics. If you want to research and put together a user guide section, you could work on #3947. This issue is asking for a section on using the Search Editor feature. That would be a good first time contributor issue and you would learn about the cool Search Editor. I'll close this PR for now.
Thanks for the advice, the search editor seems like something more fit for me, I'd love to learn more about it. I'll comment under the issue to learn more about it so I can start work. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge extensibility extension author content under /api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants