Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing documented "Contribution Points" #5230

Open
rioj7 opened this issue Mar 12, 2022 · 5 comments
Open

missing documented "Contribution Points" #5230

rioj7 opened this issue Mar 12, 2022 · 5 comments
Labels
doc-bug out of date, inaccurate, confusing content extensibility extension author content under /api

Comments

@rioj7
Copy link

rioj7 commented Mar 12, 2022

Not all Contribution Points are documented.

If you use the completion items in package.json the following are missing from the doc page:

  • authentication
  • codeActions
  • css.customData
  • documentation
  • html.customData
  • iconFonts
  • localizations
  • markdown.markdownItPlugins
  • markdown.previewScripts
  • markdown.previewStyles
  • notebookRenderer
  • notebooks
  • remoteHelp
  • semanticTokenModifiers
  • semanticTokenScopes
  • semanticTokenTypes
  • terminal

css.customData and html.customData have the following text in the description

The file paths are relative to workspace and only workspace folder settings are considered.

But that must be for the settings css.customData and html.customData. For contributes.css.customData and contributes.html.customData it should be relative to extension folder.

@gregvanl gregvanl added extensibility extension author content under /api doc-bug out of date, inaccurate, confusing content labels Mar 13, 2022
@joey2031
Copy link
Contributor

joey2031 commented May 14, 2022

Hey I'm new and would like to contribute. I can help out with this. Just add the missing points you outlined to contribution-points.md, with the links? Also I'll make sure the list is in alphabetical order. Just one question: Where can I find the corresponding links? Thanks

@rioj7
Copy link
Author

rioj7 commented May 15, 2022

@joey2031 Do these links point to some explanation, why don't you amend the last commit, what is the use of correcting typo's in new commits.

@joey2031
Copy link
Contributor

joey2031 commented May 15, 2022

@joey2031 Do these links point to some explanation, why don't you amend the last commit, what is the use of correcting typo's in new commits.
No these links do not point to anything, but I noticed all the other Contribution Points had a link like that. I could not find the source or where those links came from so I thought I'll just try to put in new ones following the format. TBH I don't know what to put for the links (or if I should just leave it blank), I was hoping someone can help me with that. Also I didn't know about git amend (didn't notice the typos till after I committed). If you can tell me where those links come from I'd be happy to fix them, thanks for the feedback.

@rioj7
Copy link
Author

rioj7 commented May 15, 2022

@joey2031 The whole point of this issue is the missing explanation of these contribution points, All contribution points on the current page have their link point to a section with some explanation in the same page.

I think when they decide to merge this PR they can collapse all commits into 1 merge commit.

@joey2031
Copy link
Contributor

@joey2031 The whole point of this issue is the missing explanation of these contribution points, All contribution points on the current page have their link point to a section with some explanation in the same page.

I think when they decide to merge this PR they can collapse all commits into 1 merge commit.

Oh I see, so I would also need to write the new explanations? I thought it was just the missing links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-bug out of date, inaccurate, confusing content extensibility extension author content under /api
Projects
None yet
Development

No branches or pull requests

3 participants