Fix flakiness on test Log_WhenAsyncFlush_StreamWriterIsCalledOnlyWhenLogLevelAllowsIt #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
approved these changes
Dec 19, 2024
Youssef1313
reviewed
Dec 19, 2024
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Logging/FileLoggerTests.cs
Outdated
Show resolved
Hide resolved
Youssef1313
previously approved these changes
Dec 19, 2024
Evangelink
dismissed stale reviews from Youssef1313 and MarcoRossignoli
via
7941ced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For netfx, we would queue the message and we have a second loop reading from the queue. It's possible that when we assert, we still have not read. Now we ensure the loop is flushed before reading.