Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception if ExpectedExceptionBaseAttribute is applied more than once #4358

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Throw exception if ExpectedExceptionBaseAttribute is applied more than once #4358

merged 3 commits into from
Dec 16, 2024

Conversation

Youssef1313
Copy link
Member

Fixes #4331

Evangelink
Evangelink previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please backport to rel/3.7

@Evangelink Evangelink enabled auto-merge (squash) December 16, 2024 11:59
@Youssef1313 Youssef1313 mentioned this pull request Dec 16, 2024
Merged
@Evangelink Evangelink merged commit d6d6bbe into microsoft:main Dec 16, 2024
10 checks passed
@Youssef1313 Youssef1313 deleted the throw-multiple-expectedexception branch December 16, 2024 14:19
Evangelink pushed a commit to Evangelink/testfx that referenced this pull request Dec 17, 2024
@Youssef1313 @Evangelink
Throw exception if ExpectedExceptionBaseAttribute is applied more tha…
215746e 
…n once (microsoft#4358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UTA_MultipleExpectedExceptionsOnTestMethod is unused
2 participants
@Youssef1313 @Evangelink