Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Assert.Throws(Async) and Assert.ThrowsExactly(Async) APIs #4350

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Introduce Assert.Throws(Async) and Assert.ThrowsExactly(Async) APIs #4350

merged 3 commits into from
Dec 14, 2024

Conversation

Evangelink
Copy link
Member

Contribute to #4257

@Evangelink Evangelink enabled auto-merge (squash) December 13, 2024 20:39
Youssef1313
Youssef1313 reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add EditorBrowsable(Never) to the existing ThrowsException(Async) APIs to avoid confusion when typing Assert.Throws and invoke completion in IDE?

@Evangelink
Copy link
Member Author

Should we add EditorBrowsable(Never) to the existing ThrowsException(Async) APIs to avoid confusion when typing Assert.Throws and invoke completion in IDE?

Yes! I never remember this trick! Done!

@Evangelink Evangelink disabled auto-merge December 14, 2024 19:35
@Evangelink Evangelink merged commit b10bda3 into microsoft:main Dec 14, 2024
10 checks passed
@Evangelink Evangelink deleted the throws branch December 14, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evangelink @Youssef1313