Avoid more overhead of assembly initialize #4349
Draft
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Dec 13, 2024
Comment on lines
+165
to
+170
| if (!testMethodInfo.Parent.Parent.IsAssemblyInitializeExecuted) | ||
| { | ||
| assemblyInitializeResult = RunAssemblyInitializeIfNeeded(testMethodInfo, testContext); | ||
| } | ||
|
|
||
| if (assemblyInitializeResult != null && assemblyInitializeResult.Outcome != UnitTestOutcome.Passed) |
There was a problem hiding this comment.
This changes the semantics of the code I think.
Previously, if assembly initialize failed, we will attach the failure for every single test run. While now, it's only attached for the first test.
There was a problem hiding this comment.
from the code it looks like we prepare to capture outputs of the initialize method in every single test, but we actually run zero times or one time. so hopefully this changes nothing. We just prevent setting up capturing of output for method that will immediately return.
|
Not sure why that test complains, but running against local build produces error for every test. So probably the acceptance test is wrong: |
|
same for class init: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we are spending about 1% of the test run on 1k tests trying to setup assembly initialize contexts inside of RunAssemblyInitializeIfNeeded, only to enter the child method that would run AssemblyInitialize where we just return if we already run the code.