Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto detect DynamicDataSourceType #4340

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Dec 13, 2024

Fixes #4254

Evangelink
Evangelink previously approved these changes Dec 13, 2024
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issue with public API it seems but otherwise LGTM

src/Adapter/MSTest.TestAdapter/DynamicDataOperations.cs Outdated Show resolved Hide resolved
Evangelink
Evangelink previously approved these changes Dec 17, 2024
# Conflicts:
#	test/IntegrationTests/MSTest.Acceptance.IntegrationTests/NativeAotTests.cs
@Evangelink Evangelink merged commit f81364c into microsoft:main Dec 17, 2024
1 of 9 checks passed
@Youssef1313 Youssef1313 deleted the dynamicdata-membertype branch December 17, 2024 14:33
Evangelink added a commit to Evangelink/testfx that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify [DynamicData] to not require user to specify the member type
3 participants