Improve Regex to Reduce Matching Time

[thomhurst]

Partially fixes #4159

[nohwnd]

The new regex will not match the first line (or the other lines shown in red)

current:

new:

[Youssef1313]

@nohwnd That means we need better test coverage :)

[nohwnd]

ofc

[nohwnd]

I thought it would be caught by OutputFormattingIsCorrect test, but that runs only on code we have symbols for, so the line is there. So probably best to add unit test for this, once we figure out what the problem is, if that is just the system being really slow, or some input throwing the regex into a really bad state.

[thomhurst]

Ah good shout! I've just added a test for the regex. What do you think?

[nohwnd]

The test looks good.

[thomhurst]

A very marginal improvement on the regex performance, but an improvement none-the-less:

https://github.com/thomhurst/MSTP-Stacktrace-Regex-Benchmark/actions/runs/12053547703/job/33609479485#step:4:660

[Evangelink]

@thomhurst I haven't followed in details teh discussion. Is the PR already handling the timeout case that you reported in the issue?

[thomhurst]

It doesn't handle the timeout, but it improves performance and adds a specific AOT stacktrace regex:

https://github.com/thomhurst/MSTP-Stacktrace-Regex-Benchmark/actions/runs/12055817470/job/33618423983#step:4:2023

[Evangelink]

Ok let me merge this one and make sure the timeout part remains open.