Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSTEST0034: Use CleanupBehavior.EndOfClass on ClassCleanupAttribute #3289

Merged
merged 22 commits into from
Jul 23, 2024
Merged

MSTEST0034: Use CleanupBehavior.EndOfClass on ClassCleanupAttribute #3289

merged 22 commits into from
Jul 23, 2024

Conversation

engyebrahim
Copy link
Member

fix: #3227

@engyebrahim engyebrahim marked this pull request as ready for review July 22, 2024 17:32
@engyebrahim engyebrahim mentioned this pull request Jul 22, 2024
Merged
Evangelink
Evangelink previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the few tests with inhertiance behavior but otherwise LGTM :shipit:

@Evangelink Evangelink changed the title Analyzer that flags [ClassCleanup] where the cleanup behavior is not set MSTEST0034: Use CleanupBehavior.EndOfClass on ClassCleanupAttribute Jul 22, 2024
Evangelink
Evangelink approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you @engyebrahim

@Evangelink Evangelink enabled auto-merge (squash) July 23, 2024 09:58
@Evangelink Evangelink merged commit 7bccb49 into main Jul 23, 2024
7 checks passed
@Evangelink Evangelink deleted the Enji/classcleanup branch July 23, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analyzer that flags [ClassCleanup] where the cleanup behavior is not set
2 participants
@engyebrahim @Evangelink