Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open-source platform extensions and tooling #3133

Merged
merged 9 commits into from
Jun 21, 2024

Conversation

Evangelink
Copy link
Member

@Evangelink Evangelink commented Jun 19, 2024

Following recent update, we are open sourcing all the extensions required for a behavior similar to VSTest.

Extracting code from https://github.com/microsoft/testanywhere/commit/2549f8dc1f973ae67c5d2cbf36e87131fd53c420

@Evangelink
Copy link
Member Author

I still need to work on fixing the acceptance tests and review linux build/test behavior

@Evangelink Evangelink marked this pull request as ready for review June 21, 2024 07:48
Directory.Build.props Outdated Show resolved Hide resolved
Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding the exact commit and link to repo from which you took the copy, so we can track changes back into history, even if internally.

@@ -29,9 +29,13 @@
<!-- Core -->
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(MicrosoftNETTestSdkVersion)" VersionOverride="$(MicrosoftNETTestSdkVersion)" Sdk="MSTest" />
<!-- Most of the times this dependency is not required but we leave the opportunity to align the version of the platform being used -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future readers, consider commenting when it is not needed, and in which situation it might be needed. Because 2 years from now we won't know and will be afraid to remove this.

src/Platform/Directory.Build.props Outdated Show resolved Hide resolved
@Evangelink Evangelink merged commit 04cfbbc into microsoft:main Jun 21, 2024
1 check passed
@Evangelink Evangelink deleted the platform-extensions branch June 21, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants