Add support for WorkItemAttribute analyzer #2180
Conversation
There was a problem hiding this comment.
I'll fix MSTEST0007 and merge this one right after. Thanks for the work here @cvpoienaru.
| @@ -198,7 +198,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MSTest.Performance.Runner", | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Playground", "samples\Playground\Playground.csproj", "{8A41B37E-0732-4F28-B214-A44233B447FE}" | |||
| EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "MSTest.Acceptance.IntegrationTests", "test\IntegrationTests\MSTest.Acceptance.IntegrationTests\MSTest.Acceptance.IntegrationTests.csproj", "{BCB42780-C559-40B6-8C4A-85EBC464AAA8}" | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MSTest.Acceptance.IntegrationTests", "test\IntegrationTests\MSTest.Acceptance.IntegrationTests\MSTest.Acceptance.IntegrationTests.csproj", "{BCB42780-C559-40B6-8C4A-85EBC464AAA8}" | |||
There was a problem hiding this comment.
Was it some automatic change?
|
|
||
| Rule ID | Category | Severity | Notes | ||
| --------|----------|----------|------- | ||
| MSTEST0010 | Usage | Info | WorkItemAttributeOnTestMethodAnalyzer |
There was a problem hiding this comment.
Let's make this one 8 as it will be the first I merge (after #2176). Also, it seems that the rule is also not handling the notes part correctly so we will need to fix it by hand copying the rule description.
| @@ -11,4 +11,5 @@ internal static class DiagnosticIds | |||
| public const string PublicTypeShouldBeTestClassRuleId = "MSTEST0004"; | |||
| public const string TestContextShouldBeValidRuleId = "MSTEST0005"; | |||
| public const string AvoidExpectedExceptionAttributeRuleId = "MSTEST0006"; | |||
| public const string WorkItemAttributeOnTestMethodRuleId = "MSTEST0010"; | |||
There was a problem hiding this comment.
| public const string WorkItemAttributeOnTestMethodRuleId = "MSTEST0010"; | |
| public const string WorkItemAttributeOnTestMethodRuleId = "MSTEST0008"; |
| <value>[WorkItem] can only be set on methods marked with [TestMethod]</value> | ||
| </data> | ||
| <data name="WorkItemAttributeOnTestMethodAnalyzerTitle" xml:space="preserve"> | ||
| <value>WorkItemAttribute should be set on TestMethod</value> |
There was a problem hiding this comment.
I am thinking that maybe we want to go with Invalid usage of [WorkItem].
| { | ||
| if (methodAttribute.AttributeClass.Inherits(testMethodAttributeSymbol)) | ||
| { | ||
| hasTestMethodAttribute = true; |
There was a problem hiding this comment.
Probably worth adding a continue; here so we don't also do the next check.
|
@cvpoienary Can you please rebase to use the helper from #2176 (and use naming similar to what I did) |
|
As discussed, we will close this rule and provide a single rule that would check all the attributes that should only be set on test methods. Thanks for the contribution @cvpoienaru |
Pull request was closed
Add support for WorkItemAttribute analyzer