Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fabricitem): use generics for properties #140

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor(fabricitem): use generics for properties #140

wants to merge 2 commits into from
+1,668 −84

Conversation

DariuszPorowski
Copy link
Member

@DariuszPorowski DariuszPorowski commented Dec 11, 2024 •
edited
Loading

📥 Pull Request

❓ What are you trying to address

WIP

✨ Description of new changes

WIP

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Changelog Preview

v0.1.0-dev - December 18, 2024

✨ Added

  • #140 Added extended properties to fabric_spark_job_definition Data Source.

💫 Changed

  • #126 Enhance error handling by improving the diagnostic message - add additional error details, error codes and request ID.
  • #148 Enabled SPN support for Eventstream

Copilot
Copilot AI reviewed Dec 11, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated no suggestions.

Files not reviewed (4)
  • internal/provider/provider.go: Evaluated as low risk
  • internal/pkg/fabricitem/data_schema.go: Evaluated as low risk
  • internal/services/sparkjobdefinition/data_spark_job_definition_test.go: Evaluated as low risk
  • docs/data-sources/spark_job_definition.md: Evaluated as low risk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@DariuszPorowski DariuszPorowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DariuszPorowski @codecov-commenter