-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically enable AdjustIndistinguishableColors if High Contrast mode enabled #17346
base: main
Are you sure you want to change the base?
Conversation
For the record, |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Hmm that's odd. Your PR doesn't touch anything like that. You may have to just do a good 'ol |
I think @PankajBhojwani has some research on this with JTippet |
I wonder if we also want to increase the delta e threshold we use when we detect high contrast mode! That was what we discussed with Jeffrey Tippet (3 years ago at this point wow), his response was along the lines of "that makes sense, though know that this isn't the way win32 apps work". I think how color nudging should work with HC is something that likely needs more discussion/potentially a spec, but automatically turning on the feature when in HC mode makes sense as a start. |
Ah, sounds like you're talking about this. 😏 |
5d0ba39
to
04691f4
Compare
Summary of the Pull Request
If High Contrast mode is enabled in the OS settings, we now automatically enable
adjustIndistinguishableColors
. To accomplish this, a newAutomatic
value is added toadjustIndistinguishableColors
. When it's chosen, color nudging doesn't occur in regular contrast sessions, but we interpret the value asIndexed
respectively.The new default value is
AutomaticIndexed
. Meaning that regular contrast sessions will see no difference in behavior. However, if they switch to high contrast mode, Windows Terminal will interpret the value asIndexed
at runtime. This was chosen becauseAlways
is more performance intensive.References and Relevant Issues
#12999
Validation Steps Performed
✅ Toggling High Contrast mode immediately triggers an updated terminal instance with
adjustIndistinguishableColors