-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SolidColorBrush to AcrylicBrush in MainPage.xaml #17198
base: main
Are you sure you want to change the base?
Change SolidColorBrush to AcrylicBrush in MainPage.xaml #17198
Conversation
@microsoft-github-policy-service agree |
@carlos-zamora Any news on this PR? 😄 |
Hey @AlejandroBlanco2001! I'm so sorry that we let this sit - I think we marked it up to be discussed by the team, and I'm the one who had an objection. We forgot to take notes, follow up, and help you get this in. That's on me. My main concern is that it will make the settings look out of place on Windows 11. It's better than it being broken on Windows 10, but I was wondering if there was a way for us to use "Conditional Xaml" to make these resources work properly and look native on both 10 and 11. |
@zadjii-msft has a thought as well: "Does the transparent background also cause an overlap on Windows 11? Because if so, condition XAML won't help" |
Hey @DHowett, I don't have Windows 11 on any of my machines, but I could check on a friend's PC today if you need that feedback. |
Summary of the Pull Request
In the MainPage.xaml, change the SolidColorBrush to AcrylicBrush to be able to alter the color of the panel when it cannot be rendered
References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
In #12973, we changed the way of rendering the panel to use a SolidColorBrush with a transparent background. However, when this cannot be rendered, it causes an error of overlapping. Therefore, this change is to revert this panel to the original implementation introduced in #9752, using AcrylicBrush and setting the color to 'SystemChromeMediumLowColor' when it cannot be rendered.
Validation Steps Performed
PR Checklist