-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: improved text_search folder testing #9984
Open
eavanvalkenburg
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
eavanvalkenburg:improve_data_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Python: improved text_search folder testing #9984
eavanvalkenburg
wants to merge
7
commits into
microsoft:main
from
eavanvalkenburg:improve_data_tests
+1,439
−960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Dec 16, 2024
github-actions
bot
changed the title
improved text_search folder testing
Python: improved text_search folder testing
Dec 16, 2024
moonbox3
approved these changes
Dec 16, 2024
eavanvalkenburg
force-pushed
the
improve_data_tests
branch
from
December 17, 2024 09:07
c9bfc9a
to
6055520
Compare
TaoChenOSU
reviewed
Dec 17, 2024
python/semantic_kernel/connectors/memory/azure_ai_search/azure_ai_search_collection.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/azure_ai_search/azure_ai_search_collection.py
Show resolved
Hide resolved
eavanvalkenburg
force-pushed
the
improve_data_tests
branch
from
December 18, 2024 11:11
a9c4f58
to
9d3af87
Compare
TaoChenOSU
reviewed
Dec 18, 2024
TaoChenOSU
approved these changes
Dec 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
added unit tests to up the test coverage across the data folder
Also redoes exceptions for everything vector.
This does introduce some breaking changes on the exceptions returned by the different methods for vector stores, they are still marked experimental and this will go a long way in moving towards release.
Closes #9485
Description
Contribution Checklist