-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Upgrade Minimum Onnx Version to enable MacOS Unit Tests #9981
base: main
Are you sure you want to change the base?
Conversation
enabled test cases for mac os upgraded uv.lock file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, don't we also have integration tests for onnx? Any updates needed there?
@nmoeller thanks for handling this. To Eduard's question, I do see the following in our integration tests: semantic-kernel/python/tests/integration/completions/chat_completion_test_base.py Line 76 in 62a50f3
|
@eavanvalkenburg @moonbox3 i am currently working on this. I also want to fully integrate my tests into your ci/cd and currently exploring options. I think i would have to adjust the github actions to download the onnx model.
But i am currently try to setup, the integration Pipeline on my Fork to test my CI/CD Changes. |
@nmoeller thanks for this work, adding integration tests is a bit complex because they first have to be in, before they run since they have access to all the keys, etc. So I would focus on the new code in this PR and then we can collaborate on adding a integration test for this separately, if you want to have a look, we just split the ollama tests into separate ones to get a bit less time taken for the merge, and also make it easier to debug, I would suggest the same for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small notes, could you also add the same marks for onnx as are in the test_chat_completions for ollama (and add that tag to pyproject)?
@@ -22,6 +21,8 @@ | |||
from semantic_kernel.connectors.ai.google.vertex_ai import VertexAIChatCompletion, VertexAIChatPromptExecutionSettings | |||
from semantic_kernel.connectors.ai.mistral_ai import MistralAIChatCompletion, MistralAIChatPromptExecutionSettings | |||
from semantic_kernel.connectors.ai.ollama import OllamaChatCompletion, OllamaChatPromptExecutionSettings | |||
from semantic_kernel.connectors.ai.onnx import OnnxGenAIChatCompletion, OnnxGenAIPromptExecutionSettings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally ONNXTemplate is also available from .onnx, could you check and make the change if needed?
@@ -22,6 +21,8 @@ | |||
from semantic_kernel.connectors.ai.google.vertex_ai import VertexAIChatCompletion, VertexAIChatPromptExecutionSettings | |||
from semantic_kernel.connectors.ai.mistral_ai import MistralAIChatCompletion, MistralAIChatPromptExecutionSettings | |||
from semantic_kernel.connectors.ai.ollama import OllamaChatCompletion, OllamaChatPromptExecutionSettings | |||
from semantic_kernel.connectors.ai.onnx import OnnxGenAIChatCompletion, OnnxGenAIPromptExecutionSettings | |||
from semantic_kernel.connectors.ai.onnx.utils import ONNXTemplate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from semantic_kernel.connectors.ai.onnx.utils import ONNXTemplate | |
from semantic_kernel.connectors.ai.onnx import ONNXTemplate |
Closes : #9979
enabled test cases for mac os
upgraded uv.lock file
Motivation and Context
Using version 0.4.0 did not provide a pip package for MacOS, which forced us to disabled Unit Tests on MacOs
With version 0.5.0 available we can enable the unit Tests for MacOS.
Using Version 0.5.0 will enable following features for users :
Contribution Checklist