Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling controls API renames according to offical API review #2921

Merged
merged 3 commits into from
Jul 16, 2020

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented Jul 15, 2020

These are API renames that resulted from the API committee's review of the ScrollView control (microsoft/microsoft-ui-xaml-specs#56). Just a bunch of find-and-replace operations with no functional changes.

I'm not going to list all the renames - the summaries are basically present in the 3 .idl files.

(I have another PR coming next, specifically for the addition of a CurrentAnchor property to align with the old ScrollViewer.)

@RBrid RBrid requested a review from a team July 15, 2020 18:19
@RBrid RBrid self-assigned this Jul 15, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jul 15, 2020
@RBrid
Copy link
Contributor Author

RBrid commented Jul 15, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jul 15, 2020
@RBrid
Copy link
Contributor Author

RBrid commented Jul 16, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj
Copy link
Contributor

@RBrid Looks like there are a few test failures.

@RBrid
Copy link
Contributor Author

RBrid commented Jul 16, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@RBrid RBrid merged commit 507826e into master Jul 16, 2020
@RBrid RBrid deleted the user/rbrid/ScrollingControlsAPIRenamesPR branch July 16, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Scrolling team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants