Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersonPictureSettings API review #13

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

PersonPictureSettings API review #13

wants to merge 7 commits into from

Conversation

MikeHillberg
Copy link
Contributor

No description provided.

@MikeHillberg MikeHillberg requested a review from a team as a code owner March 1, 2019 15:51
@jevansaks
Copy link
Member

@MikeHillberg what are the next steps here? Should I make some of the clarifying / proposed edits in your branch and push the update to resolve the comments or should I let you do that?

jevansaks
jevansaks approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@jevansaks jevansaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an API review person but I approve this PR.

@jevansaks jevansaks mentioned this pull request Mar 11, 2019
Closed
@MikeHillberg MikeHillberg mentioned this pull request Mar 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jevansaks jevansaks jevansaks approved these changes

@jonwis jonwis jonwis left review comments

@oldnewthing oldnewthing oldnewthing left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeHillberg @jevansaks @oldnewthing @jonwis