-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformer Logs: Save to separate file #3553
base: main
Are you sure you want to change the base?
Conversation
Set transformer property 'enable_file_logging' to True to save the transformer logs to file
5124496
to
1bb0db2
Compare
Is this PR to save transformer logs in a separated file, or the transformer logs are not in the whole log file? |
It is to save to a separate file. Corrected the title. |
Why does it need to save to separated files? Which scenario does it need? The current env/test split log is easy to understand, but transformer is a LISA concept. It would be confusing to have separated log. |
The primary motivation for this PR was the usage in kernel installer. I thought it makes sense to write the kernel installer log to a separate file. Alternatively, we can update the kernel installer transformer to write logs to a file, but I felt having a generic logging solution is better, in case others have similar use cases for different transformer |
Thank you for telling where the separated log file is used. But I cannot understand why it's needed. In the most scenarios, the kernel installer transformer runs early stage with single thread. It should be easy view in the whole log. |
When we want to process the log (eg: using AI) or upload the log (eg: upload the log of kernel build), it is difficult to read from the full lisa log |
Set transformer property 'enable_file_logging' to True to save the transformer logs to separate file