Added ip_power control for BareMetal platform #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase on latest main to avoid conflict. |
squirrelsc
reviewed
Dec 9, 2024
| from .schema import IPPowerSchema | ||
|
|
||
|
|
||
| class IPPower(subclasses.BaseClassWithRunbookMixin, ContextMixin, InitializableMixin): |
There was a problem hiding this comment.
- Inherit from features.StartStop.
- Move it under
cluster/generic.
squirrelsc
reviewed
Dec 9, 2024
| @dataclass | ||
| class IPPowerSchema(schema.TypedSchema, schema.ExtendableSchemaMixin): | ||
| type: str = field(default="Ip9285", metadata=field_metadata(required=True)) | ||
| hostname: str = "" |
squirrelsc
reviewed
Dec 9, 2024
| class Ip9285(IPPower): | ||
| def __init__(self, runbook: IPPowerSchema) -> None: | ||
| super().__init__(runbook) | ||
| self._request_cmd = ( |
There was a problem hiding this comment.
What does the P6 mean? If it's part of the port, move it to on/off, so it's clearer.
squirrelsc
reviewed
Dec 9, 2024
| def type_schema(cls) -> Type[schema.TypedSchema]: | ||
| return IPPowerSchema | ||
|
|
||
| def on(self, port: int) -> None: |
There was a problem hiding this comment.
Change the type of port to str, because maybe other type uses a name instead of an int.
squirrelsc
reviewed
Dec 9, 2024
|
|
||
| def on(self, port: int) -> None: | ||
| request_on = f"{self._request_cmd}{port}=1" | ||
| requests.get(request_on) |
There was a problem hiding this comment.
Follow the internal example to check the status, make sure it's reliable.
Co-authored-by: paull <[email protected]>
…to paull/ippower
# This is the 1st commit message: Added ip_power control for BareMetal platform # The commit message microsoft#2 will be skipped: # Added tftp deployment on BareMetal platform (microsoft#3422) # # Co-authored-by: paull <[email protected]>
…to paull/ippower
paulli2017
force-pushed
the
paull/ippower
branch
from
3e96684 to
43ecb77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.