Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for enums or collection of enums as root payload #4360

Merged
merged 9 commits into from
Mar 21, 2024
Merged

add support for enums or collection of enums as root payload #4360

merged 9 commits into from
Mar 21, 2024

Conversation

koros
Copy link
Contributor

@koros koros commented Mar 19, 2024 •
edited by baywet
Loading

@koros koros requested a review from a team as a code owner March 19, 2024 20:29
andrueastman
andrueastman previously approved these changes Mar 20, 2024
View reviewed changes
@andrueastman andrueastman dismissed their stale review March 20, 2024 06:47

Confirm abstraction method.

andrueastman
andrueastman previously approved these changes Mar 20, 2024
View reviewed changes
baywet
baywet previously approved these changes Mar 20, 2024
View reviewed changes
@koros koros dismissed stale reviews from baywet and andrueastman via 2beee9e March 20, 2024 17:47
baywet
baywet requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something went wrong with your last merge, can you rebase please?

git switch main
git pull -p
git switch feature/typescript/support-enum-as-root-payload
git rebase main
git push -f

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@baywet baywet merged commit 66ce57b into main Mar 21, 2024
193 checks passed
@baywet baywet deleted the feature/typescript/support-enum-as-root-payload branch March 21, 2024 12:18
@koros koros restored the feature/typescript/support-enum-as-root-payload branch October 2, 2024 11:27
@koros koros deleted the feature/typescript/support-enum-as-root-payload branch October 2, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TS] Regression in handling enums Add support for Enums or collection of enum values as root of the payload
3 participants
@koros @andrueastman @baywet