SendPrimitiveAsync throws InvalidOperationException for enums #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Before merging
- update changelog in repository root.
- update version at
kiota-dotnet/Directory.Build.props
Line 4 in 0bc980f
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Vincent Biret <[email protected]>
MartinM85
force-pushed
the
fix/247-enums-sendprimitiveasync
branch
from
1eabf75 to
982faa6
Compare
baywet
reviewed
Jul 11, 2024
tests/trimming/Microsoft.Kiota.Trimming.Validation/Microsoft.Kiota.Trimming.Validation.csproj
Show resolved
Hide resolved
baywet
reviewed
Jul 12, 2024
baywet
reviewed
Jul 12, 2024
baywet
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
LGTM. Thanks for the continuous work on this one. @andrueastman for final review and merge.
andrueastman
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Look good to me.
Really appreciate the work here @MartinM85
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #274