Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IParseNode.GetCollectionOf* methods can now return null #174

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Irame
Copy link

@Irame Irame commented Jan 11, 2024

Made the return type of GetCollectionOfPrimitiveValues, GetCollectionOfEnumValues and GetCollectionOfObjectValues in IParseNode nullable to allow for null when the underlying type is not an collection type.

This change is part of the solution for the problem discussed here microsoft/kiota#3976.

@Irame
Copy link
Author

Irame commented Jan 11, 2024

@microsoft-github-policy-service agree

@Irame Irame changed the title GetCollectionOf* methods of IParseNode can now return null IParseNode.GetCollectionOf* methods of IParseNode can now return null Jan 11, 2024
@Irame Irame changed the title IParseNode.GetCollectionOf* methods of IParseNode can now return null IParseNode.GetCollectionOf* methods can now return null Jan 12, 2024

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Conflicts have been resolved. A maintainer will take a look shortly.

Copy link
Contributor

github-actions bot commented May 6, 2024

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New📃
Development

Successfully merging this pull request may close these issues.

2 participants