Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply community recommended tsconfig for Node 16 #947

Open
wants to merge 267 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
267 commits
Select commit Hold shift + click to select a range
c41ab80
Remove commented code.
stephenmichaelf Nov 15, 2017
954f052
Remove unnecessary code.
stephenmichaelf Nov 15, 2017
306ddaa
Add TFS 2017 Update 3 agent version.
stephenmichaelf Nov 27, 2017
86fbbed
Update yml config.
stephenmichaelf Nov 27, 2017
924b02e
Fix mac pool.
stephenmichaelf Nov 27, 2017
671a240
Merge pull request #300 from Microsoft/users/stfrance/add-agent-version
stephenmichaelf Nov 28, 2017
a4be372
Added video (#301)
masters3d Nov 29, 2017
0217b3a
Add task.json schema file (#146)
AArnott Jan 29, 2018
ad4047c
remove extra schema info (#308)
ericsciple Jan 29, 2018
2ea9157
link to task json schema (#309)
ericsciple Feb 6, 2018
91e03a1
Merge pull request #295 from Microsoft/users/stfrance/resourcefiles
stephenmichaelf Feb 7, 2018
b7b47e4
Fix escaping property values. (#311)
stephenmichaelf Feb 8, 2018
bfddff3
Error on multiline secret (#315)
ericsciple Feb 22, 2018
c70eaca
Handback. (#316)
stephenmichaelf Feb 23, 2018
00f310f
add trigger into yaml
ericsciple Mar 1, 2018
72eb910
change queues
ericsciple Mar 1, 2018
1bbd289
Refactor compile exe helper functions
ericsciple Mar 2, 2018
bda1c27
Update dependencies to prevent warnings during npm install. (#325)
stephenmichaelf Mar 6, 2018
0811d35
Update dependency versions. (#327)
stephenmichaelf Mar 6, 2018
216fed2
Update dependency versions. (#328)
stephenmichaelf Mar 13, 2018
22e9d33
Add option to pipe to file and another tool
madhurig Mar 14, 2018
54cba4e
Update TaskLibAnswers to have all supported commands (#332)
brcrista Mar 21, 2018
4c75ff7
PR feedback, add tests
madhurig Mar 23, 2018
288a43f
close filestream correctly
madhurig Mar 23, 2018
e4fd4e8
Users/stfrance/oss (#331)
stephenmichaelf Mar 23, 2018
953cf2e
guard for timing issues where filestream of first tool is not closed
madhurig Mar 23, 2018
05038e6
add error message for linux
madhurig Mar 23, 2018
d99b570
Refactor as per offline discussion with Eric
madhurig Mar 27, 2018
057056b
close stream after setting returncode
madhurig Mar 27, 2018
f22b24b
Merge pull request #329 from Microsoft/users/madhurig/pipeToFileAndTool
Mar 27, 2018
6c3c61d
add optional parameter to getHttpProxyConfig allow bypass filter. (#324)
TingluoHuang Mar 29, 2018
d3b2d15
Missed a couple mocked commands. Bump patch version (#334)
brcrista Apr 2, 2018
f56d971
Fix indentation for table of contents
ericsciple Apr 15, 2018
1a3ba0d
update docs
ericsciple Apr 15, 2018
8a1a8a9
allow broken symlink
ericsciple Apr 18, 2018
2904356
Update schema to support showEnvironmentBlock (#350)
darthwillis May 2, 2018
bc5701b
Added quoutes around test tooling invocation
mmajcica May 12, 2018
caf32e0
Fixed isses with $env:TMP in PS Tests
mmajcica May 12, 2018
790560a
Added SecureFile functions in PS SDK
mmajcica May 12, 2018
b16a151
Adding secureFile input type in task.json scheme
madhurig Apr 17, 2018
29a04de
Added missing logging commands (#361)
mmajcica May 18, 2018
a96eb8b
Update typescript version
brcrista May 18, 2018
856c48e
Fix low-hanging fruit
brcrista May 18, 2018
d3379b6
Fix more low-hanging fruit
brcrista May 18, 2018
eacd7f7
Temporarily add .gitignore
brcrista May 18, 2018
b61ba63
Fix nullable IExecOptions
brcrista May 18, 2018
a210ba3
Delete .gitignore
brcrista May 18, 2018
8c8f46c
Bump major version number
brcrista May 18, 2018
83eb474
Simplify a few things
brcrista May 18, 2018
7dca1fc
v0.11.0 (#363)
ericsciple May 21, 2018
0af0d33
Simplify some of the type annotations
brcrista May 21, 2018
1b1d33d
norc on bash -c for test failing on certain environments
bryanmacfarlane Jun 19, 2018
89c94b4
Add back some type annotations
brcrista Jun 22, 2018
b461216
Merge branch 'master' into users/brcrista/strict-null-checks
brcrista Jun 22, 2018
9cedd04
Update timeout. (#375)
stephenmichaelf Jun 26, 2018
6b9c4f4
Add missing comma (#377)
sandorfr Jun 30, 2018
3a7905b
Adding a new API to get the test run system from the publisher tasks.…
navin22 Jul 5, 2018
2e45727
Increase timeout. (#378)
stephenmichaelf Jul 5, 2018
1195328
Fix timeout. (#379)
stephenmichaelf Jul 5, 2018
d9e5806
Find-Match in powershell does not support searching a pattern in a pa…
Thilas Jul 12, 2018
f6ac006
Update docs (#390)
hashtagchris Aug 14, 2018
491cf85
Add mocks for proxy helpers
keithrob Sep 13, 2018
d61bacb
Merge pull request #399 from Microsoft/users/kerobert/fixPoxyMocks
keithrob Sep 13, 2018
800dadc
handle exit event; added overload for setResult to expose a 'done' bo…
ericsciple Oct 1, 2018
0b96551
v2.7.0 (#407)
ericsciple Oct 1, 2018
0c87341
Take care of some simple doucmentation issues (#411)
Oct 10, 2018
de5f350
Update TestingAndDebugging.md (#412)
Oct 10, 2018
2b01428
rebrand
bryanmacfarlane Oct 13, 2018
36d132f
update heading
bryanmacfarlane Oct 13, 2018
66384f0
more rebranding
bryanmacfarlane Oct 14, 2018
f57b4ff
update yaml
bryanmacfarlane Oct 14, 2018
3ba5575
job typo
bryanmacfarlane Oct 14, 2018
c319ce1
space typo
bryanmacfarlane Oct 14, 2018
99ba16b
update links
bryanmacfarlane Oct 15, 2018
066c8c2
Fix badges. (#456)
stephenmichaelf Oct 15, 2018
b9602e0
Update links and string in documents from rebranding (#457)
Oct 16, 2018
154a4ea
Change reference to VSTS to Azure DevOps (#406)
thomasrayner Oct 17, 2018
9cb1dc3
Fixed broken links for reference examples (#393)
joshmgross Oct 17, 2018
d716f57
branding misses
bryanmacfarlane Nov 10, 2018
d981996
typo
bryanmacfarlane Nov 10, 2018
350e635
bump
bryanmacfarlane Nov 10, 2018
9fdd82c
unc arg issue (#474)
bryanmacfarlane Nov 17, 2018
7015476
Added missing logging commands to Node lib (#477)
mmajcica Nov 27, 2018
e0a9634
Fix issues with enum (#478)
Nov 27, 2018
683b3b4
Update documentation to point to correct source (#470)
Nov 27, 2018
4abe456
Bump
Nov 27, 2018
033aba5
bump
bryanmacfarlane Nov 27, 2018
2f0dde7
Updating schema (#479)
jessehouwing Dec 3, 2018
7e4c001
Mock stdline and errline (#462)
Dec 12, 2018
578d70c
rename VSTS to Azure DevOps (#484)
SebastianSchuetze Dec 19, 2018
045cdeb
Example correction (#486)
gjrfytn Jan 2, 2019
1a7e4dd
Fix executable check in _tryGetExecutablePath (#421)
Feb 5, 2019
fa4a786
Get tests running again (#494)
Feb 6, 2019
0a110b8
Added setVariableName method (#419)
Feb 12, 2019
58e6201
Upgrade to TypeScript 3 (#459)
Feb 12, 2019
4a77fd6
Updated dependencies from component governance (#466)
Feb 12, 2019
3f2176c
Update release notes for 2.8.0 (#495)
Feb 12, 2019
2b465ae
Fix an small typo in the documentation (#497)
judavi Feb 14, 2019
3ca1b0e
Add missing "type" on connectService string pattern (#384)
sandorfr Feb 14, 2019
f46409f
Updating documentation (#461)
Feb 14, 2019
5143ee8
Add `getPlatform` function (#374)
brcrista Feb 15, 2019
0574f6c
Update with `getPlatform` change
Feb 15, 2019
98a98c7
Include a note on ARM and x86 agent support (#402)
juliobbv Mar 4, 2019
aa02e7f
Updated vault to encode secrets using cipheriv (#505)
Mar 8, 2019
b284022
FI master
brcrista Mar 9, 2019
df7bf53
React to changes in toolrunner
brcrista Mar 9, 2019
c4cdcf2
fix build errors in mock-task
brcrista Mar 9, 2019
58ee961
simplify mock-task.FsStats
brcrista Mar 9, 2019
29137f1
Require non-null pipeOutputToTool
brcrista Mar 10, 2019
64605eb
Annotate optional properties on IExecOptions
brcrista Mar 10, 2019
aa41fd5
Remove unused code in mock-toolrunner
brcrista Mar 10, 2019
f8be449
PR feedback
brcrista Mar 11, 2019
002fff7
Bump to 3.0.0-preview
brcrista Mar 11, 2019
97f225f
Merge pull request #362 from Microsoft/users/brcrista/strict-null-checks
brcrista Mar 11, 2019
7373857
Add enums to mock-task
brcrista Mar 12, 2019
a4139ea
FI master
brcrista Mar 12, 2019
12db892
Merge pull request #507 from Microsoft/users/brcrista/mock-task-enums
brcrista Mar 12, 2019
f41749c
Detect correct node handler (#503)
Mar 13, 2019
a1bbaef
Run ci on changes to releases branch
Mar 15, 2019
cad6050
Add setSecret to mock-task. (#512)
hashtagchris Mar 23, 2019
11c9439
Mock every exported function in task-lib. (#514)
hashtagchris Mar 25, 2019
3fb9071
Fix infinite loop (#483)
Apr 8, 2019
059405c
Clean environment after running mocks
Apr 8, 2019
385f267
Revert "Clean environment after running mocks"
Apr 8, 2019
e5a622a
Clean environment after running mocks (#526)
Apr 9, 2019
ca5952d
Adds Node10 and PowerShell execution handlers. (#528)
jessehouwing Apr 11, 2019
478c983
Enable large numbers of children to be pushed in find (#509)
May 1, 2019
198b22e
Add Node environment doc (#533)
May 8, 2019
2f33a98
Drop back down to 2.9.0 - not major versioning
May 24, 2019
0829907
Update link to vsts-task to use the newer name of azure-pipelines-tas…
eriawan Jun 24, 2019
ae939a5
Remove endpoint authorization non-debug logging (SYSTEMVSSCONNECTION …
zarenner Jul 10, 2019
dd18c6a
correct issue (#564)
IanKemp Aug 19, 2019
d461757
Fixed an issue were output from command without newline was dropped
Aug 28, 2019
d9fafa9
In some instances (with pipes) adding the \n breaks things.
Aug 28, 2019
e5484f9
Back out force flag since failing test is flaky
Aug 28, 2019
363167b
Renamed one of tests with same name to identify which one is failing
Aug 28, 2019
c704159
Properly renamed duplicate tests
Aug 28, 2019
c4e9ae2
Merge pull request #567 from microsoft/users/jtpetty/loststreamdata
Sep 4, 2019
40b9763
Escape % signs (#543)
Sep 5, 2019
68aab72
Fix rmrf and drop version to 2.9.0 (#531)
Sep 5, 2019
554c7e6
Dont perform which twice when check is true (#529)
Sep 5, 2019
5bb2ea0
export write-logging command for powershell (#417)
Sep 5, 2019
89ac932
Allow empty string in toolRunner (#569)
Sep 6, 2019
3183fa8
Update task.ts (#570)
Sep 9, 2019
bd40eb8
Change some tags (#572)
vtbassmatt Sep 20, 2019
33207e0
Update version since 2.9.2 had a publishing issue
Sep 23, 2019
de0eae5
Merge pull request #576 from microsoft/users/jtpetty/versionbump
Sep 27, 2019
d685603
add missed properties to task.json schema (#560)
teh13th Oct 1, 2019
d3e1350
note about security issues
vtbassmatt Oct 24, 2019
eebbc77
Merge pull request #581 from microsoft/secure
vtbassmatt Oct 24, 2019
f64f0bf
Update tasks.schema.json
Nov 12, 2019
f2c40a3
Add missing assertion. (#588)
Nov 14, 2019
0fdbbc1
Update tasks.schema.json for missing attributes (#591)
Dec 2, 2019
6ebfd5e
added helpUrl to task.schema.json (#592)
ninallam Dec 3, 2019
4399893
Resolves Newtonsoft.Json loading against 2019 version of the TFS Clie…
jessehouwing Dec 12, 2019
9e19afd
Added sync-request as dependency (#597)
Dec 30, 2019
aae2d84
Fixed issues with generating docs. Issue #587 (#598)
Dec 30, 2019
3a9ccf2
Updated to generate correct env var keys in mock task runner (#600)
Jan 9, 2020
f81bb6f
Slight doc clarity nit (#602)
Jan 10, 2020
63d954e
fixed casing for editableoptions (#607) (#608)
lucaslra Jan 21, 2020
49a7bf3
Annotate outStream and errStream as optional (#613)
AArnott Jan 27, 2020
7f62b8a
Allow undefined env var values (#615)
AArnott Jan 27, 2020
2e3cdea
Fix doc comment for exported `rmRF` function (#616)
AArnott Jan 28, 2020
d35a5b7
Update to honor silent option for all stdout writes in exec. Fixes #6…
Jan 28, 2020
34e17f6
Remove erroneous "foo" from docs (#612)
AArnott Jan 28, 2020
14c54c2
Update to new mac pool
Mar 5, 2020
0a6b208
bump version (#619)
Mar 6, 2020
62c92b5
Add stale workflow (#626)
Apr 2, 2020
f2094a2
Adding prejobexecution (#629)
Apr 21, 2020
44869ec
Update Consuming.md (#631)
Angr1st May 5, 2020
5f230a2
Fixed documentation for tr.exec() (#633)
found-it May 6, 2020
b1c2d7f
Update stale.yml
May 11, 2020
1519dfc
Added shell property to IExecOptions (#637)
egor-bryzgalov May 12, 2020
c532de6
Permit getDelimitedInput to split on either a string or a Regexp (#638)
MorganRodgers May 19, 2020
7b32ca7
[ToolRunner] Enhanced 'shell' execution option (#643)
egor-bryzgalov Jun 18, 2020
ea7cfd9
Dont trim whitespace from inputs (#652)
Jul 23, 2020
0dbd351
Fix stdout/stderr types (#660)
alex-peck Sep 11, 2020
5f17f1c
Support node 14 tests (#661)
alex-peck Sep 17, 2020
9d73972
Add support for killing child processes with SIGINT signal (#663)
EzzhevNikita Sep 17, 2020
0d9223f
Added parameter to setResourcePath to add posibility to disable warni…
egor-bryzgalov Oct 5, 2020
cf18a23
[MockTestRunner] Fixed node version determination (#672)
DaniilShmelev Oct 13, 2020
77b9e47
Change type of the resultFiles parameter of publish method in TestPub…
max-zaytsev Oct 26, 2020
8c406fa
Automatically publish package on CI (#686)
Nov 12, 2020
90e9cde
add missed properties to tasks.schema.json (#641)
teh13th Dec 8, 2020
f7e4588
Extend setVariable to allow 'output' variables to be created (#691)
johnnyreilly Dec 10, 2020
674214d
Reverted changes for node 14 (#693)
Dec 29, 2020
a5967c3
Updated publish methods to keep it compatible (#696)
egor-bryzgalov Jan 12, 2021
0089003
Update schema for task restrictions (#705)
mjroghelia Feb 8, 2021
d431a26
Added retry logic to the cp() method (#707)
egor-bryzgalov Feb 12, 2021
578d707
Preparing for release of the 3.1.0 version (#713)
egor-bryzgalov Feb 17, 2021
4847986
Added PR opening script (#722)
egor-bryzgalov Mar 10, 2021
0347ed8
Temporary localization files renaming (#731)
egor-bryzgalov Mar 11, 2021
7f1b64a
Renamed localization folders (#732)
egor-bryzgalov Mar 11, 2021
21dac98
Fixed notification for the localization pipeline (#736)
egor-bryzgalov Mar 11, 2021
e69409b
Update to use agent-supported version of escaping (#753)
Apr 19, 2021
d2131e5
Updated package version to 3.1.1 (#756)
Apr 19, 2021
bffffa5
Bumped extension version (#757)
Apr 19, 2021
d81a453
Added workflow for automerging PRs from LEGO system (#758)
EzzhevNikita Apr 22, 2021
448ff99
Allow mirror URL to be set for NodeJS downloads (#719)
ricksbrown May 24, 2021
a9171d9
Added Auto assign action (#765)
May 26, 2021
7f912e2
Fixed token (#767)
May 31, 2021
0533838
Localization update (#768)
Jun 1, 2021
bbec8ff
Fixed issue with shell.cp retry (#769)
Jun 7, 2021
08eba60
bump package version (#764)
DaniilShmelev Jun 22, 2021
68bae9a
fix bug with escaped quotes in toolrunner _argStringToArray (#771)
AnnaOpareva Jun 29, 2021
078c422
add patch version for PR #771 (#772)
AnnaOpareva Jun 30, 2021
80eaeb9
Skipping the file if it was not found (#774)
DenisRumyantsev Jul 16, 2021
13333c9
Revert "Skipping the file if it was not found (#774)" (#778)
DenisRumyantsev Jul 19, 2021
77c834e
Retry in the find function for fs.realpathSync method for UNC-paths (…
DenisRumyantsev Jul 20, 2021
acc731b
Skipping the file if it was not found (the CI is fixed) (#779)
DenisRumyantsev Jul 23, 2021
f30e6ba
Review points fixing for 779 PR (#781)
DenisRumyantsev Jul 28, 2021
d6d1498
Update toolrunnertests.ts (#783)
Aug 4, 2021
8d46367
Fix assertAgent call (#647)
Aug 10, 2021
9b03ef7
Bump up task lib version to 3.1.7 (#786)
Aug 11, 2021
45747eb
Localization update (#762)
Aug 13, 2021
96ad5c6
Change implicit check in getResponse to explicit (#788)
kuleshovilya Aug 19, 2021
0bbb9f8
Fix documentation, comment and condition for getEndpointAuthorization…
AnnaOpareva Sep 2, 2021
ba1f94b
ubuntu image updated (#795)
DenisRumyantsev Sep 17, 2021
ac8458c
#667 Error setting resourceFile: "Maximum call stack size exceeded" …
cima Oct 6, 2021
b901eff
Fix README style typo (#807)
nulltoken Dec 24, 2021
82f3744
Resolve vulnerabilities in dependencies (#815)
AndreyIvanov42 Feb 16, 2022
2ad3b09
Add optional HostException handler in Invoke-Tool (#822)
EzzhevNikita Mar 11, 2022
9448530
Move notifications about Task-lib Localization PR from Slack to MS Te…
denis-tikhomirov Mar 11, 2022
5ebf55f
Fix return types for input functions in documentation (#826)
max-zaytsev Mar 22, 2022
a9aa775
Added new required functions (#827)
Banner-Keith May 11, 2022
7486d51
Bump patch version (#837)
SvetlanaMaliugina May 17, 2022
fb34438
added formatted proxy URL (#834)
kirill-ivlev May 25, 2022
b72e14a
Update minimatch to version 3.0.5 to fix vulnerability (#836)
kirill-ivlev May 25, 2022
ad2d00f
Microsoft mandatory file (#839)
microsoft-github-policy-service[bot] Jun 3, 2022
d4cc533
Update pipeline to include a step for publishing artifacts. (#848)
AndreyIvanov42 Jul 11, 2022
333a5f9
Update contributing.md (#847)
AndreyIvanov42 Jul 18, 2022
35bcc3f
updated docs (#853)
AndreyIvanov42 Jul 27, 2022
ee582bc
[Repo config] Add `CODEOWNERS` file (#855)
max-zaytsev Aug 23, 2022
5adadae
Enable task authors to determine whether the task is running on a hos…
Roman-Shchukin Oct 12, 2022
22ba7dd
Updated mockery and mocha because of vulnerabilities (#875)
Roman-Shchukin Nov 1, 2022
e05ff6f
Updated PSLIB_InvalidPattern0 to be more readable (#876)
abatishchev Nov 1, 2022
9ba99ac
Localization update (#887)
KonstantinTyukalov Nov 9, 2022
50bd431
Include uncought exceptions stack trace to the output logs (#895)
PavloAndriiesh Nov 22, 2022
73e9515
Pipeline fixing (#897)
Roman-Shchukin Nov 24, 2022
3bf465d
Merge task lib 4.x to master (#903)
KonstantinTyukalov Dec 2, 2022
5f76bee
Fixed Readme for npm package (#904)
max-zaytsev Dec 3, 2022
0d2f17b
Added unhandledRejection event (#912)
DmitriiBobreshev Jan 9, 2023
7d04ce6
Updated CHANGELOG.md (#915)
DmitriiBobreshev Jan 16, 2023
149de35
Described types for `argIf` (#920)
KonstantinTyukalov Feb 27, 2023
6505de9
Update autoAssignAbtt workflow (#923)
max-zaytsev Mar 15, 2023
2915809
[Bug 2029503](P2): [Component Governance Alert] - CVE-2022-24999 in q…
DmitriiBobreshev Mar 20, 2023
f7e1795
Remove note about v4 task lib status (#919)
KonstantinTyukalov Mar 31, 2023
eac6dd4
update ubuntu image (#925)
DenisRumyantsev Apr 21, 2023
4086d6b
Update ReleaseNotes for PowerShell's VstsTaskSdk (#934)
sergey-koryshev May 3, 2023
a3d940f
chore: apply community recommended `tsconfig` for Node 16
JamieMagee Jun 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove note about v4 task lib status (#919)
* Remove note about v4 task lib status

* Fix formatting
KonstantinTyukalov authored Mar 31, 2023
commit f7e17959900884f773e65b0e3d3d81ba69b6371f
31 changes: 11 additions & 20 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,5 @@
# Instructions for Contributing Code

## Current status

Since at the moment work is proceeding on migrating to Node16, you need to remember the following:

- master branch for SDK v3 (stable and targets Node10)
- releases/4.x branch for SDK v4 (preview and targets Node16)
- Changes that were merged for SDK v3 should be cherry-picked for SDK v4 once they are merged to the master branch

## Contributing bug fixes

We are currently accepting contributions in the form of bug fixes. A bug must have an issue tracking it in the issue tracker. Your pull request should include a link to the bug that you are fixing. If you've submitted a PR for a bug, please post a comment in the bug to avoid duplication of effort.
@@ -22,21 +14,20 @@ Design changes will not be accepted at this time. If you have a design change pr

You will need to complete a Contributor License Agreement (CLA). Briefly, this agreement testifies that you are granting us permission to use the submitted change according to the terms of the project's license, and that the work being submitted is under appropriate copyright.

Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit https://cla.microsoft.com to sign digitally.
Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit <https://cla.microsoft.com> to sign digitally.

## Housekeeping

Your pull request should:
Your pull request should:

* Include a description of what your change intends to do
* Be a child commit of a reasonably recent commit in the **master** branch
* Requests need not be a single commit, but should be a linear sequence of commits (i.e. no merge commits in your PR)
* Be a child commit of a reasonably recent commit in the **master** branch
* Requests need not be a single commit, but should be a linear sequence of commits (i.e. no merge commits in your PR)
* It is desirable, but not necessary, for the tests to pass at each commit
* Have clear commit messages
* e.g. "Refactor feature", "Fix issue", "Add tests for issue"
* Include adequate tests
* At least one test should fail in the absence of your non-test code changes. If your PR does not match this criteria, please specify why
* Tests should include reasonable permutations of the target fix/change
* Include baseline changes with your change
* All changed code must have 100% code coverage

* Have clear commit messages
* e.g. "Refactor feature", "Fix issue", "Add tests for issue"
* Include adequate tests
* At least one test should fail in the absence of your non-test code changes. If your PR does not match this criteria, please specify why
* Tests should include reasonable permutations of the target fix/change
* Include baseline changes with your change
* All changed code must have 100% code coverage