Defer checking of class static blocks #59607

Andarist · 2024-08-12T20:37:25Z

This only helps with a specific situation when a type alias defined in a class static block triggered the first variance check in those circular situations. Then all properties referencing A again were reentering getVariancesWorker and thus it was assumed that they were OK. My comment at the bottom of this post explains more about this kind of situation: #59606 (comment)

In other words, this only mitigates the problem in this specific situation but it's still possible to run into problems in similar circular situations.

Andarist · 2024-08-12T20:38:06Z

tests/cases/fourslash/quickInfoAvoidsClassVarianceCircularity1.ts

this one was already fixed by #53549 , this is just an extra test case

RyanCavanaugh · 2024-08-13T16:56:38Z

@typescript-bot test it

typescript-bot · 2024-08-13T16:56:42Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-13T17:16:52Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-08-13T17:19:35Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/59607/merge:

Everything looks good!

typescript-bot · 2024-08-13T17:40:58Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,532k (± 0.96%)}	_{193,533k (± 0.93%)}	_~	_192,266k	_195,901k	_{p=0.689 n=6}
_{Parse Time}	_{1.58s (± 0.53%)}	_{1.58s (± 0.65%)}	_~	_1.56s	_1.59s	_{p=0.788 n=6}
_{Bind Time}	_{0.86s (± 0.87%)}	_{0.86s (± 1.14%)}	_~	_0.85s	_0.87s	_{p=1.000 n=6}
_{Check Time}	_{11.39s (± 0.37%)}	_{11.37s (± 0.12%)}	_~	_11.35s	_11.39s	_{p=0.169 n=6}
_{Emit Time}	_{3.26s (± 0.36%)}	_{3.25s (± 0.45%)}	_~	_3.23s	_3.27s	_{p=0.142 n=6}
_{Total Time}	_{17.08s (± 0.31%)}	_{17.06s (± 0.15%)}	_~	_17.02s	_17.08s	_{p=0.102 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,757	_945,757	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,045	_410,045	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,536k (± 0.00%)}	_{1,222,555k (± 0.00%)}	_~	_1,222,517k	_1,222,615k	_{p=0.378 n=6}
_{Parse Time}	_{6.64s (± 0.44%)}	_{6.65s (± 0.36%)}	_~	_6.62s	_6.68s	_{p=0.746 n=6}
_{Bind Time}	_{1.87s (± 0.28%)}	_{1.87s (± 0.29%)}	_~	_1.86s	_1.87s	_{p=0.640 n=6}
_{Check Time}	_{31.18s (± 0.31%)}	_{31.14s (± 0.09%)}	_~	_31.10s	_31.18s	_{p=0.573 n=6}
_{Emit Time}	_{14.98s (± 0.47%)}	_{14.95s (± 0.47%)}	_~	_14.86s	_15.07s	_{p=0.686 n=6}
_{Total Time}	_{54.67s (± 0.23%)}	_{54.61s (± 0.11%)}	_~	_54.55s	_54.72s	_{p=0.336 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,491,204	_2,491,204	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,013,428	_1,013,428	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,498,634k (± 0.00%)}	_{2,498,621k (± 0.00%)}	_~	_2,498,559k	_2,498,778k	_{p=0.936 n=6}
_{Parse Time}	_{9.25s (± 0.26%)}	_{9.22s (± 0.19%)}	_~	_9.20s	_9.24s	_{p=0.167 n=6}
_{Bind Time}	_{2.19s (± 0.34%)}	_{2.18s (± 0.25%)}	_{-0.01s (- 0.61%)}	_2.17s	_2.18s	_{p=0.015 n=6}
_{Check Time}	_{75.83s (± 0.21%)}	_{75.73s (± 0.45%)}	_~	_75.33s	_76.28s	_{p=0.572 n=6}
_{Emit Time}	_{0.28s (± 2.26%)}	_{0.28s (± 2.26%)}	_~	_0.27s	_0.29s	_{p=1.000 n=6}
_{Total Time}	_{87.55s (± 0.19%)}	_{87.41s (± 0.40%)}	_~	_87.00s	_87.98s	_{p=0.226 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,395	_1,230,395	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,083	_264,083	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,351,975k (± 0.03%)}	_{2,351,334k (± 0.01%)}	_~	_2,351,071k	_2,351,677k	_{p=0.128 n=6}
_{Parse Time}	_{4.98s (± 0.63%)}	_{5.00s (± 1.08%)}	_~	_4.93s	_5.09s	_{p=0.936 n=6}
_{Bind Time}	_{1.88s (± 1.29%)}	_{1.87s (± 1.30%)}	_~	_1.84s	_1.91s	_{p=0.419 n=6}
_{Check Time}	_{34.61s (± 0.41%)}	_{34.61s (± 0.30%)}	_~	_34.43s	_34.74s	_{p=0.936 n=6}
_{Emit Time}	_{3.31s (± 1.22%)}	_{3.35s (± 0.75%)}	_~	_3.31s	_3.38s	_{p=0.107 n=6}
_{Total Time}	_{44.80s (± 0.32%)}	_{44.84s (± 0.21%)}	_~	_44.69s	_44.93s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,395	_1,230,395	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,083	_264,083	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,425,541k (± 0.03%)}	_{2,426,015k (± 0.01%)}	_~	_2,425,806k	_2,426,309k	_{p=0.093 n=6}
_{Parse Time}	_{6.25s (± 0.97%)}	_{6.20s (± 0.75%)}	_~	_6.13s	_6.26s	_{p=0.298 n=6}
_{Bind Time}	_{2.02s (± 1.12%)}	_{2.02s (± 0.92%)}	_~	_2.00s	_2.04s	_{p=0.571 n=6}
_{Check Time}	_{41.32s (± 0.35%)}	_{41.21s (± 0.25%)}	_~	_41.06s	_41.33s	_{p=0.173 n=6}
_{Emit Time}	_{4.09s (± 4.00%)}	_{4.04s (± 0.92%)}	_~	_3.99s	_4.09s	_{p=0.810 n=6}
_{Total Time}	_{53.69s (± 0.41%)}	_{53.47s (± 0.17%)}	_~	_53.38s	_53.63s	_{p=0.066 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,891	_256,891	_~	_~	_~	_{p=1.000 n=6}
_Types	_105,580	_105,580	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,091k (± 0.01%)}	_{429,231k (± 0.06%)}	_~	_429,074k	_429,786k	_{p=0.230 n=6}
_{Parse Time}	_{2.80s (± 0.27%)}	_{2.80s (± 0.43%)}	_~	_2.79s	_2.82s	_{p=0.503 n=6}
_{Bind Time}	_{1.09s (± 1.35%)}	_{1.10s (± 1.24%)}	_~	_1.07s	_1.11s	_{p=0.242 n=6}
_{Check Time}	_{15.28s (± 0.12%)}	_{15.32s (± 0.29%)}	_~	_15.26s	_15.37s	_{p=0.198 n=6}
_{Emit Time}	_{1.38s (± 0.99%)}	_{1.41s (± 0.83%)}	_{+0.02s (+ 1.68%)}	_1.39s	_1.42s	_{p=0.022 n=6}
_{Total Time}	_{20.55s (± 0.14%)}	_{20.62s (± 0.22%)}	_{+0.07s (+ 0.36%)}	_20.58s	_20.68s	_{p=0.006 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,245	_94,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,230k (± 0.03%)}	_{370,224k (± 0.03%)}	_~	_370,076k	_370,351k	_{p=0.936 n=6}
_{Parse Time}	_{3.44s (± 0.84%)}	_{3.45s (± 0.89%)}	_~	_3.42s	_3.49s	_{p=0.808 n=6}
_{Bind Time}	_{1.92s (± 0.77%)}	_{1.93s (± 0.63%)}	_~	_1.91s	_1.94s	_{p=0.451 n=6}
_{Check Time}	_{19.45s (± 0.31%)}	_{19.34s (± 0.31%)}	_{-0.10s (- 0.54%)}	_19.25s	_19.43s	_{p=0.016 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.81s (± 0.34%)}	_{24.71s (± 0.27%)}	_{-0.10s (- 0.39%)}	_24.65s	_24.84s	_{p=0.037 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,000,453	_3,000,453	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,033,584	_1,033,584	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,125,392k (± 0.00%)}	_{3,125,460k (± 0.00%)}	_~	_3,125,359k	_3,125,567k	_{p=0.173 n=6}
_{Parse Time}	_{17.03s (± 0.16%)}	_{17.05s (± 0.50%)}	_~	_16.98s	_17.21s	_{p=0.808 n=6}
_{Bind Time}	_{5.26s (± 2.03%)}	_{5.26s (± 2.07%)}	_~	_5.21s	_5.48s	_{p=0.492 n=6}
_{Check Time}	_{96.59s (± 0.21%)}	_{96.75s (± 0.20%)}	_~	_96.47s	_96.97s	_{p=0.230 n=6}
_{Emit Time}	_{24.91s (± 0.40%)}	_{25.00s (± 0.57%)}	_~	_24.79s	_25.17s	_{p=0.377 n=6}
_{Total Time}	_{143.79s (± 0.14%)}	_{144.05s (± 0.18%)}	_~	_143.63s	_144.42s	_{p=0.066 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_274,381	_274,381	_~	_~	_~	_{p=1.000 n=6}
_Types	_111,850	_111,850	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{420,774k (± 0.02%)}	_{420,711k (± 0.03%)}	_~	_420,570k	_420,860k	_{p=0.378 n=6}
_{Parse Time}	_{3.93s (± 0.77%)}	_{3.93s (± 0.32%)}	_~	_3.91s	_3.94s	_{p=0.868 n=6}
_{Bind Time}	_{1.72s (± 0.64%)}	_{1.71s (± 0.96%)}	_~	_1.69s	_1.73s	_{p=0.188 n=6}
_{Check Time}	_{17.13s (± 0.49%)}	_{17.04s (± 0.16%)}	_{-0.09s (- 0.54%)}	_17.00s	_17.08s	_{p=0.045 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.78s (± 0.37%)}	_{22.68s (± 0.20%)}	_{-0.10s (- 0.45%)}	_22.61s	_22.74s	_{p=0.045 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,779	_540,779	_~	_~	_~	_{p=1.000 n=6}
_Types	_177,884	_177,884	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,269k (± 0.01%)}	_{483,244k (± 0.01%)}	_~	_483,207k	_483,287k	_{p=0.109 n=6}
_{Parse Time}	_{3.39s (± 0.61%)}	_{3.39s (± 0.29%)}	_~	_3.38s	_3.40s	_{p=0.935 n=6}
_{Bind Time}	_{1.25s (± 0.41%)}	_{1.25s (± 0.60%)}	_~	_1.24s	_1.26s	_{p=0.784 n=6}
_{Check Time}	_{18.06s (± 0.17%)}	_{18.06s (± 0.27%)}	_~	_17.99s	_18.13s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.70s (± 0.15%)}	_{22.70s (± 0.20%)}	_~	_22.63s	_22.75s	_{p=0.681 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-13T18:41:43Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59607/merge:

Everything looks good!

Defer checking of class static blocks

82b03aa

typescript-bot assigned jakebailey Aug 12, 2024

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 12, 2024

Andarist commented Aug 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Defer checking of class static blocks #59607

Defer checking of class static blocks #59607

Andarist commented Aug 12, 2024

Andarist Aug 12, 2024

RyanCavanaugh commented Aug 13, 2024

typescript-bot commented Aug 13, 2024 •

edited

Loading

typescript-bot commented Aug 13, 2024

typescript-bot commented Aug 13, 2024

typescript-bot commented Aug 13, 2024

tsc

typescript-bot commented Aug 13, 2024

Defer checking of class static blocks #59607

Are you sure you want to change the base?

Defer checking of class static blocks #59607

Conversation

Andarist commented Aug 12, 2024

Andarist Aug 12, 2024

Choose a reason for hiding this comment

RyanCavanaugh commented Aug 13, 2024

typescript-bot commented Aug 13, 2024 • edited Loading

typescript-bot commented Aug 13, 2024

typescript-bot commented Aug 13, 2024

typescript-bot commented Aug 13, 2024

tsc

typescript-bot commented Aug 13, 2024

typescript-bot commented Aug 13, 2024 •

edited

Loading