Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report relation cache sizes in --diagnostics too #58290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakebailey
Copy link
Member

This would be helpful for microsoft/typescript-benchmarking#58, as passing --extendedDiagnostics turns on tracing which slows down the compiler (not great for benchmarking).

But, maybe this is too much info for the more generic --diagnostics printout.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 22, 2024
@jakebailey jakebailey marked this pull request as draft April 23, 2024 22:19
@DanielRosenwasser
Copy link
Member

But, maybe this is too much info for the more generic --diagnostics printout.

I might be wrong, but I think the only reason --diagnostics doesn't just do the same as --extendedDiagnostics is because we didn't want to break existing tools that parsed the output (and possibly that the latter measures things a little incorrectly?).

@jakebailey
Copy link
Member Author

Yeah, we talked about this in the meeting. It's now a lot easier to backfill data so we can change things, but the main problem is that extendedDiagnostics requires native performance events which slows down the benchmarks and makes them less realistic (since as we add more trace points, the perf gets worse with the flag on, but not for any actual user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants