Allow references to const enums when provably emitted via preserveConstEnums #57996

jakebailey · 2024-03-29T03:55:15Z

This builds on #57914, allowing references to const enums in value space when we can "prove" that they will actually be emitted due to preserveConstEnums.

Fixes #51530

jakebailey · 2024-03-29T03:56:29Z

Also, maybe this fixes #37774?

jakebailey · 2024-03-29T03:56:45Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-03-29T03:56:48Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

src/compiler/checker.ts

typescript-bot · 2024-03-29T04:01:26Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160843/artifacts?artifactName=tgz&fileId=DE8A6B6A55FC275C2C80E9AD8BC0CF251E1483AAE628B14D800392428040634102&fileName=/typescript-5.5.0-insiders.20240329.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2024-03-29T04:17:12Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-03-29T04:22:24Z

@jakebailey Here are the results of running the user tests comparing main and refs/pull/57996/merge:

Everything looks good!

typescript-bot · 2024-03-29T04:27:09Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,676k (± 0.01%)}	_{295,674k (± 0.01%)}	_~	_295,632k	_295,713k	_{p=1.000 n=6}
_{Parse Time}	_{2.66s (± 0.24%)}	_{2.67s (± 0.15%)}	_{+0.01s (+ 0.31%)}	_2.66s	_2.67s	_{p=0.033 n=6}
_{Bind Time}	_{0.83s (± 0.98%)}	_{0.83s (± 0.00%)}	_~	_0.83s	_0.83s	_{p=0.405 n=6}
_{Check Time}	_{8.24s (± 0.32%)}	_{8.24s (± 0.38%)}	_~	_8.20s	_8.28s	_{p=0.936 n=6}
_{Emit Time}	_{7.05s (± 0.39%)}	_{7.04s (± 0.24%)}	_~	_7.01s	_7.06s	_{p=0.466 n=6}
_{Total Time}	_{18.79s (± 0.21%)}	_{18.78s (± 0.21%)}	_~	_18.71s	_18.83s	_{p=0.688 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,888k (± 1.03%)}	_{193,853k (± 1.03%)}	_~	_191,982k	_195,811k	_{p=0.748 n=6}
_{Parse Time}	_{1.64s (± 1.52%)}	_{1.65s (± 1.42%)}	_~	_1.62s	_1.68s	_{p=0.871 n=6}
_{Bind Time}	_{0.88s (± 1.33%)}	_{0.88s (± 0.93%)}	_~	_0.87s	_0.89s	_{p=0.738 n=6}
_{Check Time}	_{11.28s (± 0.53%)}	_{11.25s (± 0.34%)}	_~	_11.21s	_11.30s	_{p=0.260 n=6}
_{Emit Time}	_{3.15s (± 0.49%)}	_{3.15s (± 0.44%)}	_~	_3.14s	_3.17s	_{p=0.557 n=6}
_{Total Time}	_{16.95s (± 0.40%)}	_{16.92s (± 0.27%)}	_~	_16.87s	_16.98s	_{p=0.294 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,397k (± 0.01%)}	_{347,420k (± 0.00%)}	_~	_347,410k	_347,427k	_{p=0.054 n=6}
_{Parse Time}	_{3.70s (± 0.89%)}	_{3.69s (± 0.77%)}	_~	_3.65s	_3.73s	_{p=0.686 n=6}
_{Bind Time}	_{1.38s (± 0.40%)}	_{1.37s (± 0.75%)}	_~	_1.36s	_1.39s	_{p=0.663 n=6}
_{Check Time}	_{10.24s (± 0.65%)}	_{10.24s (± 0.28%)}	_~	_10.20s	_10.28s	_{p=0.630 n=6}
_{Emit Time}	_{6.03s (± 0.47%)}	_{6.00s (± 0.54%)}	_~	_5.97s	_6.06s	_{p=0.172 n=6}
_{Total Time}	_{21.34s (± 0.36%)}	_{21.30s (± 0.29%)}	_~	_21.23s	_21.40s	_{p=0.336 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,781k (± 0.01%)}	_{302,800k (± 0.02%)}	_~	_302,753k	_302,879k	_{p=0.688 n=6}
_{Parse Time}	_{2.43s (± 0.96%)}	_{2.41s (± 1.25%)}	_~	_2.37s	_2.45s	_{p=0.293 n=6}
_{Bind Time}	_{1.19s (± 0.88%)}	_{1.22s (± 1.98%)}	_~	_1.18s	_1.25s	_{p=0.053 n=6}
_{Check Time}	_{7.52s (± 0.34%)}	_{7.52s (± 0.37%)}	_~	_7.47s	_7.55s	_{p=0.737 n=6}
_{Emit Time}	_{4.25s (± 0.52%)}	_{4.27s (± 0.57%)}	_~	_4.25s	_4.32s	_{p=0.180 n=6}
_{Total Time}	_{15.39s (± 0.17%)}	_{15.43s (± 0.23%)}	_~	_15.40s	_15.49s	_{p=0.220 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,183k (± 0.01%)}	_{510,157k (± 0.01%)}	_~	_510,043k	_510,273k	_{p=0.521 n=6}
_{Parse Time}	_{3.92s (± 0.50%)}	_{3.93s (± 0.71%)}	_~	_3.90s	_3.98s	_{p=0.934 n=6}
_{Bind Time}	_{1.46s (± 1.33%)}	_{1.45s (± 0.68%)}	_~	_1.44s	_1.46s	_{p=0.508 n=6}
_{Check Time}	_{25.42s (± 0.21%)}	_{25.45s (± 0.22%)}	_~	_25.39s	_25.55s	_{p=0.421 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{30.80s (± 0.22%)}	_{30.83s (± 0.22%)}	_~	_30.74s	_30.93s	_{p=0.469 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,744,651k (± 0.00%)}	_{1,744,680k (± 0.00%)}	_~	_1,744,644k	_1,744,753k	_{p=0.173 n=6}
_{Parse Time}	_{9.63s (± 0.71%)}	_{9.63s (± 0.65%)}	_~	_9.55s	_9.72s	_{p=1.000 n=6}
_{Bind Time}	_{3.43s (± 1.04%)}	_{3.43s (± 1.42%)}	_~	_3.37s	_3.48s	_{p=0.935 n=6}
_{Check Time}	_{81.77s (± 0.54%)}	_{81.57s (± 0.55%)}	_~	_81.03s	_82.05s	_{p=0.471 n=6}
_{Emit Time}	_{0.19s (± 4.29%)}	_{0.19s (± 2.81%)}	_~	_0.19s	_0.20s	_{p=0.855 n=6}
_{Total Time}	_{95.02s (± 0.52%)}	_{94.83s (± 0.46%)}	_~	_94.26s	_95.31s	_{p=0.470 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,397,089k (± 0.03%)}	_{2,397,332k (± 0.01%)}	_~	_2,396,858k	_2,397,682k	_{p=0.575 n=6}
_{Parse Time}	_{7.45s (± 0.82%)}	_{7.48s (± 0.62%)}	_~	_7.40s	_7.52s	_{p=0.689 n=6}
_{Bind Time}	_{2.78s (± 0.37%)}	_{2.77s (± 1.06%)}	_~	_2.73s	_2.81s	_{p=0.808 n=6}
_{Check Time}	_{49.31s (± 0.39%)}	_{49.39s (± 0.45%)}	_~	_49.13s	_49.68s	_{p=0.521 n=6}
_{Emit Time}	_{3.98s (± 1.23%)}	_{3.90s (± 1.66%)}	_~	_3.79s	_3.97s	_{p=0.065 n=6}
_{Total Time}	_{63.53s (± 0.41%)}	_{63.55s (± 0.43%)}	_~	_63.23s	_63.91s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,181k (± 0.01%)}	_{416,174k (± 0.01%)}	_~	_416,137k	_416,227k	_{p=0.810 n=6}
_{Parse Time}	_{3.34s (± 1.02%)}	_{3.35s (± 0.99%)}	_~	_3.31s	_3.39s	_{p=0.573 n=6}
_{Bind Time}	_{1.30s (± 0.63%)}	_{1.30s (± 0.58%)}	_~	_1.29s	_1.31s	_{p=0.729 n=6}
_{Check Time}	_{18.28s (± 0.35%)}	_{18.22s (± 0.26%)}	_~	_18.17s	_18.28s	_{p=0.199 n=6}
_{Emit Time}	_{1.36s (± 1.80%)}	_{1.36s (± 1.36%)}	_~	_1.34s	_1.39s	_{p=1.000 n=6}
_{Total Time}	_{24.27s (± 0.33%)}	_{24.23s (± 0.25%)}	_~	_24.17s	_24.32s	_{p=0.470 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,898,560k (± 0.00%)}	_{2,898,566k (± 0.00%)}	_~	_2,898,516k	_2,898,618k	_{p=1.000 n=6}
_{Parse Time}	_{12.96s (± 0.31%)}	_{12.96s (± 0.41%)}	_~	_12.90s	_13.04s	_{p=0.872 n=6}
_{Bind Time}	_{4.13s (± 0.60%)}	_{4.14s (± 0.52%)}	_~	_4.11s	_4.17s	_{p=0.517 n=6}
_{Check Time}	_{72.11s (± 0.55%)}	_{71.89s (± 0.42%)}	_~	_71.38s	_72.24s	_{p=0.521 n=6}
_{Emit Time}	_{19.48s (± 0.79%)}	_{19.42s (± 0.31%)}	_~	_19.34s	_19.51s	_{p=0.230 n=6}
_{Total Time}	_{108.67s (± 0.40%)}	_{108.41s (± 0.23%)}	_~	_107.98s	_108.65s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,804k (± 0.02%)}	_{408,793k (± 0.01%)}	_~	_408,748k	_408,849k	_{p=0.689 n=6}
_{Parse Time}	_{3.22s (± 0.64%)}	_{3.23s (± 0.30%)}	_~	_3.22s	_3.24s	_{p=0.565 n=6}
_{Bind Time}	_{1.41s (± 0.45%)}	_{1.41s (± 0.98%)}	_~	_1.38s	_1.42s	_{p=0.654 n=6}
_{Check Time}	_{14.30s (± 0.45%)}	_{14.31s (± 0.45%)}	_~	_14.24s	_14.42s	_{p=0.810 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.93s (± 0.24%)}	_{18.95s (± 0.37%)}	_~	_18.87s	_19.07s	_{p=0.936 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,438k (± 0.01%)}	_{513,457k (± 0.01%)}	_~	_513,406k	_513,548k	_{p=0.810 n=6}
_{Parse Time}	_{3.95s (± 0.34%)}	_{3.96s (± 0.71%)}	_~	_3.93s	_4.01s	_{p=0.572 n=6}
_{Bind Time}	_{1.89s (± 1.49%)}	_{1.88s (± 0.87%)}	_~	_1.86s	_1.90s	_{p=1.000 n=6}
_{Check Time}	_{3.42s (± 0.30%)}	_{3.43s (± 0.32%)}	_~	_3.42s	_3.44s	_{p=0.337 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.09s (± 4.62%)}	_{🔻+0.01s (+ 8.16%)}	_0.08s	_0.09s	_{p=0.034 n=6}
_{Total Time}	_{9.35s (± 0.47%)}	_{9.37s (± 0.48%)}	_~	_9.29s	_9.42s	_{p=0.470 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-03-29T05:31:50Z

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/57996/merge:

Everything looks good!

…stEnums

typescript-bot assigned jakebailey Mar 29, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 29, 2024

jakebailey commented Mar 29, 2024

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

jakebailey force-pushed the const-enum-value branch from bf0ee11 to c83323b Compare March 29, 2024 17:59

jakebailey added 2 commits March 29, 2024 11:01

Test

7f5299b

Allow references to const enums when provably emitted via preserveCon…

36042d8

…stEnums

jakebailey force-pushed the const-enum-value branch from c83323b to 36042d8 Compare March 29, 2024 18:02

jakebailey marked this pull request as ready for review March 29, 2024 19:01

jakebailey marked this pull request as draft March 29, 2024 19:01

Allow ambient again

faba9bd

DanielRosenwasser mentioned this pull request May 2, 2024

Design Meeting Notes, 3/29/2024 #58412

Open

jakebailey added 3 commits August 16, 2024 11:09

Merge branch 'main' into const-enum-value

fed9d9e

baseline

48565f0

Don't always do it

5241730

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow references to const enums when provably emitted via preserveConstEnums #57996

Allow references to const enums when provably emitted via preserveConstEnums #57996

jakebailey commented Mar 29, 2024 •

edited

Loading

jakebailey commented Mar 29, 2024

jakebailey commented Mar 29, 2024

typescript-bot commented Mar 29, 2024 •

edited

Loading

typescript-bot commented Mar 29, 2024 •

edited

Loading

typescript-bot commented Mar 29, 2024

typescript-bot commented Mar 29, 2024

typescript-bot commented Mar 29, 2024

tsc

typescript-bot commented Mar 29, 2024

Allow references to const enums when provably emitted via preserveConstEnums #57996

Are you sure you want to change the base?

Allow references to const enums when provably emitted via preserveConstEnums #57996

Conversation

jakebailey commented Mar 29, 2024 • edited Loading

jakebailey commented Mar 29, 2024

jakebailey commented Mar 29, 2024

typescript-bot commented Mar 29, 2024 • edited Loading

typescript-bot commented Mar 29, 2024 • edited Loading

typescript-bot commented Mar 29, 2024

typescript-bot commented Mar 29, 2024

typescript-bot commented Mar 29, 2024

tsc

typescript-bot commented Mar 29, 2024

jakebailey commented Mar 29, 2024 •

edited

Loading

typescript-bot commented Mar 29, 2024 •

edited

Loading

typescript-bot commented Mar 29, 2024 •

edited

Loading