Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experiment] Make intersectionState a required parameter #57989

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[experiment] Make intersectionState a required parameter #57989

wants to merge 3 commits into from

Conversation

jakebailey
Copy link
Member

This is an old experiment in response to a continued stream of bugs related to intersection state not getting passed down.

No baselines change besides cases where we do more relations, but curious to run tests.

@jakebailey
Copy link
Member Author

@typescript-bot test it

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 28, 2024
@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 28, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests comparing main and refs/pull/57989/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,689k (± 0.01%) 295,673k (± 0.01%) ~ 295,644k 295,693k p=0.128 n=6
Parse Time 2.66s (± 0.34%) 2.67s (± 0.31%) ~ 2.66s 2.68s p=0.270 n=6
Bind Time 0.83s (± 0.66%) 0.84s (± 1.39%) ~ 0.82s 0.85s p=0.498 n=6
Check Time 8.24s (± 0.34%) 8.25s (± 0.33%) ~ 8.22s 8.29s p=0.625 n=6
Emit Time 7.03s (± 0.23%) 7.06s (± 0.27%) +0.03s (+ 0.40%) 7.04s 7.09s p=0.029 n=6
Total Time 18.76s (± 0.14%) 18.82s (± 0.19%) +0.05s (+ 0.29%) 18.79s 18.87s p=0.019 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 193,379k (± 0.99%) 193,238k (± 0.93%) ~ 192,031k 195,578k p=0.689 n=6
Parse Time 1.36s (± 0.72%) 1.36s (± 1.01%) ~ 1.35s 1.38s p=0.800 n=6
Bind Time 0.73s (± 0.56%) 0.73s (± 0.71%) ~ 0.72s 0.73s p=0.595 n=6
Check Time 9.56s (± 0.56%) 9.51s (± 0.29%) ~ 9.48s 9.54s p=0.077 n=6
Emit Time 2.62s (± 0.46%) 2.62s (± 0.56%) ~ 2.60s 2.64s p=0.564 n=6
Total Time 14.27s (± 0.39%) 14.22s (± 0.20%) ~ 14.19s 14.27s p=0.126 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,399k (± 0.00%) 347,404k (± 0.01%) ~ 347,377k 347,431k p=0.748 n=6
Parse Time 2.48s (± 0.36%) 2.48s (± 0.40%) ~ 2.47s 2.50s p=0.931 n=6
Bind Time 0.93s (± 0.44%) 0.93s (± 0.00%) ~ 0.93s 0.93s p=0.405 n=6
Check Time 7.04s (± 0.32%) 7.01s (± 0.37%) -0.02s (- 0.36%) 6.99s 7.06s p=0.043 n=6
Emit Time 4.07s (± 0.20%) 4.07s (± 0.29%) ~ 4.05s 4.08s p=0.720 n=6
Total Time 14.51s (± 0.22%) 14.49s (± 0.29%) ~ 14.45s 14.57s p=0.226 n=6
TFS - node (v18.15.0, x64)
Memory used 302,794k (± 0.01%) 302,788k (± 0.01%) ~ 302,766k 302,844k p=0.688 n=6
Parse Time 2.40s (± 0.61%) 2.41s (± 1.51%) ~ 2.37s 2.46s p=0.746 n=6
Bind Time 1.19s (± 0.63%) 1.23s (± 0.95%) +0.04s (+ 3.36%) 1.22s 1.25s p=0.005 n=6
Check Time 7.52s (± 0.37%) 7.53s (± 0.26%) ~ 7.50s 7.55s p=0.746 n=6
Emit Time 4.28s (± 0.65%) 4.25s (± 0.54%) ~ 4.23s 4.29s p=0.088 n=6
Total Time 15.39s (± 0.25%) 15.41s (± 0.36%) ~ 15.34s 15.47s p=0.298 n=6
material-ui - node (v18.15.0, x64)
Memory used 510,034k (± 0.00%) 510,158k (± 0.01%) +124k (+ 0.02%) 510,111k 510,185k p=0.005 n=6
Parse Time 2.66s (± 0.55%) 2.67s (± 0.19%) ~ 2.66s 2.67s p=0.247 n=6
Bind Time 0.99s (± 0.90%) 0.99s (± 0.76%) ~ 0.98s 1.00s p=0.798 n=6
Check Time 17.33s (± 0.32%) 17.41s (± 0.47%) ~ 17.29s 17.50s p=0.128 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.98s (± 0.29%) 21.06s (± 0.39%) ~ 20.94s 21.15s p=0.093 n=6
mui-docs - node (v18.15.0, x64)
Memory used 1,744,658k (± 0.00%) 1,744,696k (± 0.00%) ~ 1,744,645k 1,744,774k p=0.128 n=6
Parse Time 7.78s (± 0.11%) 7.79s (± 0.78%) ~ 7.74s 7.90s p=1.000 n=6
Bind Time 2.80s (± 0.35%) 2.80s (± 1.31%) ~ 2.73s 2.83s p=0.677 n=6
Check Time 66.81s (± 0.46%) 66.72s (± 0.39%) ~ 66.38s 67.04s p=0.575 n=6
Emit Time 0.15s (± 3.53%) 0.16s (± 2.58%) ~ 0.15s 0.16s p=0.282 n=6
Total Time 77.55s (± 0.39%) 77.47s (± 0.36%) ~ 77.13s 77.80s p=0.810 n=6
self-build-src - node (v18.15.0, x64)
Memory used 2,396,502k (± 0.04%) 2,396,816k (± 0.01%) ~ 2,396,542k 2,396,995k p=1.000 n=6
Parse Time 6.00s (± 0.80%) 6.03s (± 0.99%) ~ 5.94s 6.09s p=0.298 n=6
Bind Time 2.27s (± 1.04%) 2.26s (± 1.35%) ~ 2.22s 2.31s p=0.686 n=6
Check Time 39.95s (± 0.41%) 39.95s (± 0.38%) ~ 39.74s 40.15s p=0.936 n=6
Emit Time 3.17s (± 0.93%) 3.18s (± 0.99%) ~ 3.14s 3.22s p=0.936 n=6
Total Time 51.41s (± 0.31%) 51.45s (± 0.31%) ~ 51.23s 51.65s p=0.575 n=6
self-compiler - node (v18.15.0, x64)
Memory used 415,855k (± 0.01%) 415,966k (± 0.01%) +111k (+ 0.03%) 415,931k 416,045k p=0.005 n=6
Parse Time 4.10s (± 0.80%) 4.16s (± 0.32%) +0.05s (+ 1.34%) 4.14s 4.18s p=0.022 n=6
Bind Time 1.59s (± 0.76%) 1.60s (± 1.09%) ~ 1.58s 1.63s p=0.325 n=6
Check Time 22.59s (± 0.25%) 22.55s (± 0.38%) ~ 22.46s 22.66s p=0.378 n=6
Emit Time 1.68s (± 1.64%) 1.68s (± 2.55%) ~ 1.61s 1.72s p=0.686 n=6
Total Time 29.97s (± 0.22%) 29.99s (± 0.20%) ~ 29.92s 30.07s p=0.573 n=6
vscode - node (v18.15.0, x64)
Memory used 2,898,195k (± 0.00%) 2,898,170k (± 0.00%) ~ 2,898,033k 2,898,262k p=0.575 n=6
Parse Time 15.92s (± 0.52%) 15.93s (± 0.30%) ~ 15.88s 15.99s p=0.871 n=6
Bind Time 5.00s (± 0.58%) 5.00s (± 0.45%) ~ 4.97s 5.03s p=0.935 n=6
Check Time 87.08s (± 0.54%) 86.80s (± 0.21%) ~ 86.51s 87.09s p=0.199 n=6
Emit Time 23.56s (± 0.32%) 23.65s (± 0.48%) ~ 23.52s 23.80s p=0.149 n=6
Total Time 131.55s (± 0.32%) 131.38s (± 0.16%) ~ 130.97s 131.56s p=0.230 n=6
webpack - node (v18.15.0, x64)
Memory used 408,947k (± 0.02%) 408,963k (± 0.02%) ~ 408,850k 409,111k p=1.000 n=6
Parse Time 4.80s (± 0.67%) 4.79s (± 0.60%) ~ 4.75s 4.82s p=0.623 n=6
Bind Time 2.06s (± 0.69%) 2.05s (± 0.91%) ~ 2.04s 2.09s p=0.462 n=6
Check Time 20.80s (± 0.31%) 20.91s (± 0.29%) +0.10s (+ 0.50%) 20.82s 20.98s p=0.030 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 27.66s (± 0.36%) 27.76s (± 0.29%) ~ 27.64s 27.85s p=0.106 n=6
xstate - node (v18.15.0, x64)
Memory used 513,460k (± 0.01%) 511,418k (± 0.01%) -2,043k (- 0.40%) 511,377k 511,450k p=0.005 n=6
Parse Time 3.94s (± 0.41%) 3.96s (± 0.65%) ~ 3.93s 4.00s p=0.122 n=6
Bind Time 1.88s (± 1.53%) 1.88s (± 1.36%) ~ 1.86s 1.92s p=0.514 n=6
Check Time 3.44s (± 0.59%) 3.34s (± 0.62%) 🟩-0.10s (- 3.05%) 3.31s 3.37s p=0.005 n=6
Emit Time 0.09s (± 9.41%) 0.10s (± 5.34%) 🔻+0.01s (+11.54%) 0.09s 0.10s p=0.023 n=6
Total Time 9.36s (± 0.55%) 9.26s (± 0.55%) -0.09s (- 0.98%) 9.20s 9.32s p=0.010 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/57989/merge:

Something interesting changed - please have a look.

Details

backstage/backstage

6 of 13 projects failed to build with the old tsc and were ignored

packages/cli/templates/default-react-plugin-package/tsconfig.json

@jakebailey
Copy link
Member Author

No baseline change but a top repos error; definitely need to pull that test in.

@jakebailey
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 28, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 28, 2024 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160827/artifacts?artifactName=tgz&fileId=5E8DDC52200C065E97E60B091DF4C7F65EEEF44964EE127FFA7D996F5148F15D02&fileName=/typescript-5.5.0-insiders.20240328.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@Andarist
Copy link
Contributor

Andarist commented Mar 28, 2024 •
edited
Loading

For posterity, the code from the break above: TS playground

@jakebailey
Copy link
Member Author

I still don't really understand this code to know if I actually introduced a good error, or am causing a bad one.

@Andarist
Copy link
Contributor

Andarist commented Apr 1, 2024

Today that intersection state is "lost" here. With your change TS decides that it can't relate those in typeRelatedToIndexInfo based on this logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakebailey @typescript-bot @Andarist