Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Monaco faster and refactor code base #32477

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Aaron-Junker
Copy link
Collaborator

Summary of the Pull Request

  • Monaco is loads now a little bit faster
  • Refactored a lot of stuff
    • For instance we now do no longer need to do string manipulation on index.html and we load it directly from memory.
    • Removed FileHandler.cs

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

}
AreBrowserExtensionsEnabled = false,
EnableTrackingPrevention = false,
AdditionalBrowserArguments = "--disable-background-networking --disable-sync --disable-web-security --disable-client-side-phishing-detection --disable-component-extensions-with-backgroud-pages --disable-features=Translate,CalculateNativeWinOcclusion,BackForwardCache,HeavyAdPrivacyMitigations, --disable-renderer-backgrounding",

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

backgrounding is not a recognized word. (unrecognized-spelling)
}
AreBrowserExtensionsEnabled = false,
EnableTrackingPrevention = false,
AdditionalBrowserArguments = "--disable-background-networking --disable-sync --disable-web-security --disable-client-side-phishing-detection --disable-component-extensions-with-backgroud-pages --disable-features=Translate,CalculateNativeWinOcclusion,BackForwardCache,HeavyAdPrivacyMitigations, --disable-renderer-backgrounding",

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

phishing is not a recognized word. (unrecognized-spelling)
@Aaron-Junker Aaron-Junker added the Needs-Review This Pull Request awaits the review of a maintainer. label Apr 16, 2024

This comment has been minimized.

@Aaron-Junker Aaron-Junker marked this pull request as draft April 21, 2024 12:34
@Aaron-Junker Aaron-Junker removed the Needs-Review This Pull Request awaits the review of a maintainer. label Apr 21, 2024

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (2)

backgrounding
phishing

Previously acknowledged words that are now absent applayout appsfolder buildtask cswinrt directshow DOPUS GBarm netcore nugets QDir systemsettings SYSTEMWOW telem TOTALCMD USEPOSITION USESIZE winappdriver xplorer 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:microsoft/PowerToys.git repository
on the dev/aaron-junker/monaco-fast-laod branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/11086918898/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (1931) from .github/actions/spell-check/expect.txt and unrecognized words (2)

Dictionary Entries Covers Uniquely
cspell:r/src/r.txt 543 1 1
cspell:cpp/src/people.txt 23 1
cspell:cpp/src/ecosystem.txt 51 1

Consider adding them (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries:
          cspell:r/src/r.txt
          cspell:cpp/src/people.txt
          cspell:cpp/src/ecosystem.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''
Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 1
ℹ️ non-alpha-in-dictionary 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants