Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileLocksmith] Switch IPC between ctx menu dll and UI from writing to file to pipe #31556

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

stefansjfw
Copy link
Collaborator

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tested local and release CI build

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a test, but restarting as administrator seems to break this change. Perhaps that's one of the reasons why it used a file in the first place? 🤔

@jaimecbernardo
Copy link
Collaborator

I mean opening file locksmith and then pressing the "restart as administrator" button from inside the app:
image

@jaimecbernardo
Copy link
Collaborator

Higher priorities at this moment. Changing it to a draft for the time being.

@jaimecbernardo jaimecbernardo marked this pull request as draft March 20, 2024 12:06
@Jay-o-Way
Copy link
Collaborator

@stefansjfw how is this going? 🙂

@stefansjfw
Copy link
Collaborator Author

@stefansjfw how is this going? 🙂

Still on hold. What Jaime said in the comment above... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants