Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring KeyVisual #31256

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Refactoring KeyVisual #31256

wants to merge 8 commits into from

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Feb 2, 2024 •
edited
Loading

  • Refactored KeyVisual so it's easier to maintain going forward. It's not using Styles which allows for more customization and drives visual alignment.
  • Replaced the ListView on the KBM page with an ItemsControl so the disabled state is now visually the same as regular SettingsCards

image

image

Disabled state for KBM
image

Jay-o-Way
Jay-o-Way reviewed Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small things. And of course a screenshot would be lovely :)

src/settings-ui/Settings.UI/SettingsXAML/Views/MouseUtilsPage.xaml Show resolved Hide resolved
src/settings-ui/Settings.UI/SettingsXAML/Controls/KeyVisual/KeyVisual.xaml Show resolved Hide resolved
src/settings-ui/Settings.UI/SettingsXAML/Controls/KeyVisual/KeyVisual.xaml Outdated Show resolved Hide resolved
jaimecbernardo
jaimecbernardo requested changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.
Tested and reviewed the changes and it LGTM!
There's one nit, though. When there's a key that's not set I think it looks a bit worse now:
This is 0.78:
image

This is this PR:
image

It's not clear that these are editable, like before.

@Jay-o-Way
Copy link
Collaborator

The Edit icon is missing

@crutkas
Copy link
Member

crutkas commented Mar 3, 2024

@niels9001, i look at this and what made me really like the old style is it was clear the key combo due to the visual break.

Maybe another view point could be what i sent over in teams.

@Jay-o-Way Jay-o-Way added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 24, 2024
@htcfreek
Copy link
Collaborator

htcfreek commented Jun 25, 2024 •
edited
Loading

I like to mention #32944 as it makes sense to address it in this PR and is maybe a solution for the problem @jaimecbernardo mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-o-Way Jay-o-Way Jay-o-Way left review comments

@jaimecbernardo jaimecbernardo jaimecbernardo requested changes

@stefansjfw stefansjfw Awaiting requested review from stefansjfw

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@niels9001 @Jay-o-Way @crutkas @htcfreek @jaimecbernardo