Quotation mark

[warquys]

Add Quotation mark

Add local quotation based on VK_OEM_7(0xDE) key.
Not all quotes have been added, only ‟ „ ” « » ‚ , ‘ ’ › ‹ '「 」 《 》 『 』〈 〉
Why not added :

• ⹂ ⌜ ⌝ ❛ ❜ ❝ ❞ 🙶 🙷 🙸 ＇ ｢ ｣ its redundant and would make too much and not readable.
• ﹁ ﹂ ﹃ ﹄ I did not put them because there use for horizontal text

PR Checklist

• Closes: Language relevant punctuations in Quick Accent. #29371 Add quotation marks to Quick Accent  #24832
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places (None)
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

This PR is currently a draft, I still need to know if adding language-related keyboard management is a good idea or specifying the use of a gobal key to make it easier to manage all the keyboards in one. Some languages ​​can use different keyboards, I think this would become problematic if the keyboard does not match the key used by default. However, using a universal key can also pose an issue to finding the key. that remains to be discussed

Validation Steps Performed

[warquys]

@microsoft-github-policy-service agree

[jaimecbernardo]

Thanks for opening the PR. I've tried to test it, but it looks like VK_OEM_7 is not present in my keyboard. These look like they'll only be available in some keyboards, depending on language. Would it make sense to add it to a different key that's more prevalent? Wonder if . makes sense, but I'm open to other ideas as well.

[jaimecbernardo]

Perhaps the comma key, since it sort of looks like a quote? 🤷

[warquys]

I think . is better because , is curenlty use for mathematical simbol from Portuguese.
If i add it to , it will be to much.

[Jay-o-Way]

Hi. Is this pr ready?

[warquys]

yes, i test it a last time.
If you're not reading this message do not pusj it yet, I would like to send you a screen shot to show you what it looks like. Maybe it's too much on one key.

[warquys]

For me there is to much on a same key.
I've also noticed that the slide bar can't be used

[warquys]

I suggest roll back the commit and use VK_QUOT_

[warquys]

Maybe move the mathematics symbols will be a better options. But i do not now on what key to put theme and if you are ok with this.

I put the pull request back into draft. Because even if technically the code works, I am clearly not satisfied with the result.

[warquys]

To give a little feedback. I'm thinking of working on character display. It seems that when there are too many characters, the display go out of screen.
This seems to be linked to the use of the window being floating and the use of VirtualizingStackPanel. VirtualizingStackPanel wants to take up as much space as possible. leading to an overflow out of the screen.

• I don't know if opening another pull request would be a solution, or adding it to the one if it's suitable.
• I don't know yet how to fix this bug, I need to document on it.
• Maybe I should i open an issue?

Sorry it's taking so long for this pool request

[warquys]

I consider having finished, but I would like a last review.

I want to point out that the display (when put on all the languages) go still outisde the screen.

Sorry, i just find out if you put the display postion of the disspaly Right you get an issue.

I added focus on the curent char via `ScrollIntoView' when the user changes the active char.

[warquys]

Miss click.

I defined the maximum width that the window could have.
This seems complete to me, I tested it on various resolutions. However, I would still like you to test it.

[warquys]

@Jay-o-Way The pr is ready.