Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones] Fix #25353 setting page bouncing #28995

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quyenvsp
Copy link
Contributor

@quyenvsp quyenvsp commented Oct 4, 2023

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Fix FancyZones setting page bouncing when scroll to bottom (issue because combobox in this page use StackPanel make it bouncing when scroll to bottom > Use normal combobox)

Validation Steps Performed

  • Open FancyZones setting page > Scroll to bottom > Verify no bouncing anymore

@crutkas
Copy link
Member

crutkas commented Oct 6, 2023

Using a trackpad, i can still get the bounce to happen. Via a mouse scroll wheel, i cannot get this to repro in any state.

Observation:
Zones sections, having both Zone behavior and appearance expanded, i can get it to stutter, but if either is collapsed, i cannot. If i change to "Custom colors", It does not repro.

100% repro via trackpad with these two fully expanded.

That makes me believe this isn't the correct solution, the problem is somewhere in the "Zones" area and maybe something isn't being collapsed correctly.

@crutkas crutkas marked this pull request as draft October 6, 2023 05:45
@crutkas
Copy link
Member

crutkas commented Oct 6, 2023

shifting to a draft PR due to it still occurs.

@crutkas
Copy link
Member

crutkas commented Oct 6, 2023

Also, @quyenvsp, thank you very much for taking the time for creating a PR here, i do want to stress that

@quyenvsp
Copy link
Contributor Author

quyenvsp commented Oct 6, 2023

@crutkas Oh I am using desktop so don't know Touchpad has problem, I will check again. My fix is for Mouse scroll wheel in special case Have 2 Textbox in page expanded then 100% mouse scroll will bouncing

You can repro by temp code in main branch
Duplicate exclude textbox at src/settings-ui/Settings.UI/SettingsXAML/Views/FancyZonesPage.xaml:244~253

Then use mouse wheel to see it bouncing, then do same with this MR it will not happen.

@Jay-o-Way Jay-o-Way added the Product-Settings The standalone PowerToys Settings application label Oct 8, 2023
Copy link
Collaborator

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details

<data name="FancyZones_MoveWindowBasedOnRelativePosition_Accessible.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Windows key + Up, down, left or right arrow key to move windows based on relative position</value>
<data name="FancyZones_MoveWindowBasedOnRelativePosition_Accessible.Content" xml:space="preserve">
<value>Windows key + Up, down, left or right based on relative position</value>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all of them begin with a capital letter?

<data name="FancyZones_MoveWindowBasedOnRelativePosition.Text" xml:space="preserve">
<value>Relative position</value>
<data name="FancyZones_MoveWindowLeftRightBasedOnZoneIndex_Accessible.Content" xml:space="preserve">
<value>Windows key + Left or right based on zone index</value>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Settings The standalone PowerToys Settings application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants