-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FancyZones] Fix #25353 setting page bouncing #28995
base: main
Are you sure you want to change the base?
[FancyZones] Fix #25353 setting page bouncing #28995
Conversation
Using a trackpad, i can still get the bounce to happen. Via a mouse scroll wheel, i cannot get this to repro in any state. Observation: 100% repro via trackpad with these two fully expanded. That makes me believe this isn't the correct solution, the problem is somewhere in the "Zones" area and maybe something isn't being collapsed correctly. |
shifting to a draft PR due to it still occurs. |
Also, @quyenvsp, thank you very much for taking the time for creating a PR here, i do want to stress that |
@crutkas Oh I am using desktop so don't know Touchpad has problem, I will check again. My fix is for Mouse scroll wheel in special case You can repro by temp code in Then use mouse wheel to see it bouncing, then do same with this MR it will not happen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details
<data name="FancyZones_MoveWindowBasedOnRelativePosition_Accessible.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve"> | ||
<value>Windows key + Up, down, left or right arrow key to move windows based on relative position</value> | ||
<data name="FancyZones_MoveWindowBasedOnRelativePosition_Accessible.Content" xml:space="preserve"> | ||
<value>Windows key + Up, down, left or right based on relative position</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all of them begin with a capital letter?
<data name="FancyZones_MoveWindowBasedOnRelativePosition.Text" xml:space="preserve"> | ||
<value>Relative position</value> | ||
<data name="FancyZones_MoveWindowLeftRightBasedOnZoneIndex_Accessible.Content" xml:space="preserve"> | ||
<value>Windows key + Left or right based on zone index</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed