This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
Allow Configuration.MetadataDocumentUri to use relative paths (ref: #76) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the example code has MetadataDocumentUri pointing to a URI.
However, in most scenarios a URI cannot be used; since authenticatoin would be required.
In such scenarios, the solution allows a local filename to be specified. However, currently it requires that this metadata file be specified as an absolute path. This will cause issues where multiple developers are working with the same solution, but have different paths for their repositories.
To resolve this, I propose adding a new property,
ProjectRelativeMetadataDocumentUri. WhenMetadataDocumentUrihas a value this new property will be ignored. However, whenProjectRelativeMetadataDocumentUriis null the new property can be used.Host.ResolvePath(ProjectRelativeMetadataDocumentUri)can then be used when importing the configuration inApplyParametersFromConfigurationClass()to resolve the relative path to an absolute one.