New System App Module for easy file systems access

[IceOnly]

Migration of microsoft/ALAppExtensions#23225

Now that we have made several clients Universal code ready.
One of the main problems turned out to be the replacement of the file record and the file object (File.Create, File.Exists).
Some of our customers now use Azure Blob Service from the System app. Others don't have a good internet and now use a local microservice with REST API, others use Azure File Shares.
The problem is that every integration is different. I think many other partners will have the same problem.
To simplify access I have adopted the email module and created new file accounts.
With just one codeunit, a developer can now connect to various file services without having to know how they actually work. The code unit "File System" delviers everything taht is needed.

An additional PR contains three connector apps:
microsoft/ALAppExtensions#23225

This Apps will conenct:

• Azure Blob Storage
• Azure File Share
• SharePoint Online

All three service can be access over one unified interface!

New provider in the future could be:

• a OneDrive Provider
• Third Party file services

An example that shows how simple it is to use the new modules can be found here:
https://github.com/IceOnly/BC_FileSystem_Example

But before I go round the whole thing, I'm interested in whether there is any interest in the module at all.

Here are some Screenshots:

I have decided in favour of some restrictions. Paths must not start with a /. The only supported path separator is /. If services that require a \ are to be connected, this must be translated by the connector app.

These restrictions should ensure that the file service can be exchanged without upgrading data.

Assigned Workitems:
Fixes #2418
Fixes AB#559148

[JesperSchulz]

This PR needs some work before the real code review can conducted.

[JesperSchulz]

@IceOnly, could I ask you to create a BCIdea (http://aka.ms/bcideas) for this? We're getting there and I now need to do the proper bookkeeping 😎

@JesperSchulz done https://experience.dynamics.com/ideas/idea/?ideaid=285f1f18-b9ac-ef11-95f5-0022485288a6

Awesome, thanks! And now that we have an idea, could you create the GitHub issue linked to the idea? Issues -> New issue -> Implement BC Idea. Then I'll approve it and we should have the proper work items in place 🥳

[JesperSchulz]

I am having one final round of reviewing and testing planned for Tuesday the 17th of December. After that, we should hopefully have the reviews needed to merge this one 🙏

[IceOnly]

@StefanMaron I fixed the most of your findings. Thank you!
Regarding the source table temporary, I would leave it as it is in the email module for now.

[StefanMaron]

• Temporary Property for a TableType = Temorary; Table
  • I can see that this can increase readability so I dont mind it being specified "twice" but in that case it should be done that way everywhere, on all variables and all pages that use those tables.
• There where a few typos and a few other smaller things I missed the first time
• Tested the runmodal with temp tables, seems like its not needed
• Tagged @JesperSchulz twice to get his view as well

But dont get me wrong, those are just minor things :) looks really great!

[JesperSchulz]

A little bit of work on the terminology (will get back with suggestions) and a bug fix, and I think we can merge. Will do some more testing Tuesday, get back to you, and we'll wrap it up 🥳

[JesperSchulz]

Ideally I think all of these objects should have been called "Storage Account" etc., but the renaming will be extensive, so let's settle for File Account. It's not like it's wrong...

[JesperSchulz]

I'm happy with the state of this PR. Now we just need one more from the product group to be happy 😊

[darjoo]

Just the permission fix, otherwise all good.

[darjoo]

Add the following codeunits here and remove their inherent entitlement/permissions.

"External File Storage"
"File Account"
"File Pagination Data"
"File Scenario"

Reason for this is because they're the facade layers and should still be controlled via permissions.
The File Storage permission sets also need to be added to the following, otherwise we will get permission issues when we get a SaaS deployment.
The "File Storage - Read" should be added to src/System Application/App/Permissions/SystemApplicationRead.PermissionSet.al
The "File Storage - Edit" should be added to src/System Application/App/Permissions/SystemApplicationEdit.PermissionSet.al
The "File Storage - View" should be added to src/System Application/App/Permissions/SystemApplicationView.PermissionSet.al
The "File Storage - Objects" should be added to src/System Application/App/Permissions/SystemApplicationObjects.PermissionSet.al

[pri-kise]

@darjoo while you're looking at permissions.
What about entitlements.
a delegated admin has the entitlement for e-mail admin.
Wouldn't it be logical to add the File Storage Admin there, too?

https://github.com/microsoft/BCApps/blob/main/src/System%20Application/App/Entitlements/DelegatedAdminagentPartner.Entitlement.al