Update RSA.Codeunit.al

[MattiLE]

Summary

Overload for ToSecretXmlString to work with a private key in a pem file.

Work Item(s)

Fixes #866

Fixes AB#555892
Fixes AB#524188

[JesperSchulz]

Doesn't compile.
Also, should the private key not be a secret text, rather than text?

[JesperSchulz]

@MattiLE, compilation still fails: Error: AL0133 Argument 1: cannot convert from 'SecretText' to 'DotNet "System.ReadOnlySpan<System.Char>"'. Could you take another look? 😊

[MattiLE]

Hi @JesperSchulz, I sorry that you haven't heard from me for so long. Is there still a problem in the build process?

[JesperSchulz]

Hi @JesperSchulz, I sorry that you haven't heard from me for so long. Is there still a problem in the build process?

No worries! I was trying to fix this myself, but doesn't seem like I succeeded! Let me take another look! As soon as this compiles, we can merge - right now it just doesn't 😟

[JesperSchulz]

@MattiLE, if you can find time to make this compile, it'd be great, as I'm a bit behind on GitHub issues and PRs. There are MANY I need to look into 🥳

[MattiLE]

Hi @JesperSchulz, I am afraid that this will not work in the al context. In C# the conversion works implicitly. But it also works when I call up the explicit conversion.

ReadOnlySpan<Char> readonlyPrivateKey = MemoryExtensions.AsSpan(privateKey);

In al I get the runtime error ‘Specified method is not supported?’ with the same code.

ReadOnlySpan := MemoryExtensions.AsSpan(DotNetString);
assembly("System.Private.CoreLib")
    {
        type("System.ReadOnlySpan`1"; ReadOnlySpan) { }
        type("System.MemoryExtensions"; MemoryExtensions) { }
    }

I believe that the handling with the Generic does not work somehow.... I have not found a solution to this.

Perhaps one of you has an idea? Otherwise we have to close the PR and the conversion has to be done outside of BC :(

[JesperSchulz]

Hi @JesperSchulz, I am afraid that this will not work in the al context. In C# the conversion works implicitly. But it also works when I call up the explicit conversion.

ReadOnlySpan<Char> readonlyPrivateKey = MemoryExtensions.AsSpan(privateKey);

In al I get the runtime error ‘Specified method is not supported?’ with the same code.

ReadOnlySpan := MemoryExtensions.AsSpan(DotNetString);
assembly("System.Private.CoreLib")
    {
        type("System.ReadOnlySpan`1"; ReadOnlySpan) { }
        type("System.MemoryExtensions"; MemoryExtensions) { }
    }

I believe that the handling with the Generic does not work somehow.... I have not found a solution to this.

Perhaps one of you has an idea? Otherwise we have to close the PR and the conversion has to be done outside of BC :(

Allow us to investigate! I'll get back to you (might take a short while though).

[JesperSchulz]

@SBalslev, would you mind taking a look at this one?

[JesperSchulz]

Just stumbled over this one, which ran into a similar issue: #309. Not sure how to get around this. DevTools (Steffen), you're up 😊

[JesperSchulz]

I will discuss with @SBalslev in the coming weeks. There's a "right", but expensive solution, and there's a "workaround", which would come cheaper. We will hopefully soon be able to conclude.

[MattiLE]

I will discuss with @SBalslev in the coming weeks. There's a "right", but expensive solution, and there's a "workaround", which would come cheaper. We will hopefully soon be able to conclude.

Hey @JesperSchulz , thanks for your efforts