[Edit-In Excel] Improve metadata handling #1721
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanSosic
reviewed
Aug 7, 2024
| @@ -14,6 +15,42 @@ codeunit 1481 "Edit in Excel" | |||
| { | |||
| Access = Public; | |||
|
|
|||
| procedure CreateMetadataWebRequest() | |||
There was a problem hiding this comment.
Whats with this procedure?
Does nothing? Init local variable and one declared variable not used.
| @@ -14,6 +15,42 @@ codeunit 1481 "Edit in Excel" | |||
| { | |||
| Access = Public; | |||
|
|
|||
| procedure CreateMetadataWebRequest() | |||
| var | |||
| EnvironmentInfo: Codeunit "Environment Information"; | |||
There was a problem hiding this comment.
This one should be name space using System.Environment;
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| namespace System.Integration.Excel; | |||
|
|
|||
| using System; | |||
There was a problem hiding this comment.
using System.Environment;
| EntitySetName: Text; | ||
| begin | ||
| MetadataUrl := 'https://metadatastoragexyz.blob.core.windows.net/metadata/metadata.xml?sp=r&st=2024-08-02T09:38:22Z&se=2024-08-02T17:38:22Z&spr=https&sv=2022-11-02&sr=b&sig=eP4pvx1m1OiiGVhYVD4haMIYvSgOAWIUysk3mD7h8Ds%3D'; | ||
| EntitySetName := 'Company'; |
There was a problem hiding this comment.
I don't see this necessary as variable, could be hardcoded with //edm:EntitySet[@name="
| begin | ||
| MetadataUrl := 'https://metadatastoragexyz.blob.core.windows.net/metadata/metadata.xml?sp=r&st=2024-08-02T09:38:22Z&se=2024-08-02T17:38:22Z&spr=https&sv=2022-11-02&sr=b&sig=eP4pvx1m1OiiGVhYVD4haMIYvSgOAWIUysk3mD7h8Ds%3D'; | ||
| EntitySetName := 'Company'; | ||
| if HttpClient.Get(MetadataUrl, HttpResponseMessage) then |
There was a problem hiding this comment.
Do you need any authentication?
|
@StefanSosic I'm just prototyping some stuff .. I changed this into a draft PR instead. |
@DenLilleMand Sorry and thanks! Let's review it than when ready :) |
…etadata-errors-handling
…etadata-errors-handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently metadata errors only appear when you open the Exported Excel Workbook, it is not clear if:
This change sets out to lessen the confusion about these errors and make the feedback instantaneous in cases where it was not possible to generate the required metadata.
This change should also be accompanied by documentation updates on how the users can debug metadata generation failures.
Work Item(s)
Fixes AB#542840