Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketing Text AI Tests Added #1504

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename test
qasimikram committed Jul 9, 2024
commit 2b1ed5f0a7ce768267f34f3593dec79124da7b09
Original file line number Diff line number Diff line change
@@ -5,17 +5,17 @@

namespace System.Test.EntityText;

using System.TestTools.AITestToolkit;

Check failure on line 8 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Default) / System Application Tests (Default)

AL0791 The namespace 'TestTools' is unknown.

Check failure on line 8 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Default) / System Application Tests (Default)

AL0791 The namespace 'AITestToolkit' is unknown.

Check failure on line 8 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Clean) / System Application Tests (Clean)

AL0791 The namespace 'TestTools' is unknown.

Check failure on line 8 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Clean) / System Application Tests (Clean)

AL0791 The namespace 'AITestToolkit' is unknown.
using System.Text;

codeunit 134640 "Mkt Text Accuracy BCCT"
codeunit 134640 "Mkt Text Accuracy AIT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the tests to a folder for the time being to distinguish between AIT Tests vs regular tests?
In the near future, we maybe introduce a separate codeunit number range.

The test app is also missing the Suite Configuration (.xml) file.

{
Subtype = Test;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if TestPermissions needs to be set to disabled.


[Test]
procedure TaglineParagraphInspiring()
var
AITestContext: Codeunit "AIT Test Context";

Check failure on line 18 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Default) / System Application Tests (Default)

AL0185 Codeunit 'AIT Test Context' is missing

Check failure on line 18 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Clean) / System Application Tests (Clean)

AL0185 Codeunit 'AIT Test Context' is missing
EntityTextCod: Codeunit "Entity Text";
Facts: Dictionary of [Text, Text];
Format: Enum "Entity Text Format";
@@ -34,7 +34,7 @@
[Test]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing comments:
[Scenario]
[Given]
[When]
[Then]

Did we stop using these?

procedure TaglineParagraphFormal()
var
AITestContext: Codeunit "AIT Test Context";

Check failure on line 37 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Default) / System Application Tests (Default)

AL0185 Codeunit 'AIT Test Context' is missing

Check failure on line 37 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Clean) / System Application Tests (Clean)

AL0185 Codeunit 'AIT Test Context' is missing
EntityTextCod: Codeunit "Entity Text";
Facts: Dictionary of [Text, Text];
Format: Enum "Entity Text Format";
@@ -53,7 +53,7 @@
[Test]
procedure TaglineParagraphCreative()
var
AITestContext: Codeunit "AIT Test Context";

Check failure on line 56 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Default) / System Application Tests (Default)

AL0185 Codeunit 'AIT Test Context' is missing

Check failure on line 56 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Clean) / System Application Tests (Clean)

AL0185 Codeunit 'AIT Test Context' is missing
EntityTextCod: Codeunit "Entity Text";
Facts: Dictionary of [Text, Text];
Format: Enum "Entity Text Format";
@@ -71,7 +71,7 @@
[Test]
procedure TaglineInspiring()
var
AITestContext: Codeunit "AIT Test Context";

Check failure on line 74 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Default) / System Application Tests (Default)

AL0185 Codeunit 'AIT Test Context' is missing

Check failure on line 74 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Clean) / System Application Tests (Clean)

AL0185 Codeunit 'AIT Test Context' is missing
EntityTextCod: Codeunit "Entity Text";
Facts: Dictionary of [Text, Text];
Format: Enum "Entity Text Format";
@@ -89,7 +89,7 @@
[Test]
procedure TaglineFormal()
var
AITestContext: Codeunit "AIT Test Context";

Check failure on line 92 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Default) / System Application Tests (Default)

AL0185 Codeunit 'AIT Test Context' is missing

Check failure on line 92 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Clean) / System Application Tests (Clean)

AL0185 Codeunit 'AIT Test Context' is missing
EntityTextCod: Codeunit "Entity Text";
Facts: Dictionary of [Text, Text];
Format: Enum "Entity Text Format";
@@ -107,7 +107,7 @@
[Test]
procedure TaglineCreative()
var
AITestContext: Codeunit "AIT Test Context";

Check failure on line 110 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Default) / System Application Tests (Default)

AL0185 Codeunit 'AIT Test Context' is missing

Check failure on line 110 in src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Clean) / System Application Tests (Clean)

AL0185 Codeunit 'AIT Test Context' is missing
EntityTextCod: Codeunit "Entity Text";
Facts: Dictionary of [Text, Text];
Format: Enum "Entity Text Format";
Original file line number Diff line number Diff line change
@@ -5,10 +5,10 @@

namespace System.Test.EntityText;

using System.TestTools.AITestToolkit;

Check failure on line 8 in src/System Application/Test/EntityText/src/MktTextRedTeamAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Default) / System Application Tests (Default)

AL0791 The namespace 'TestTools' is unknown.

Check failure on line 8 in src/System Application/Test/EntityText/src/MktTextRedTeamAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Default) / System Application Tests (Default)

AL0791 The namespace 'AITestToolkit' is unknown.

Check failure on line 8 in src/System Application/Test/EntityText/src/MktTextRedTeamAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Clean) / System Application Tests (Clean)

AL0791 The namespace 'TestTools' is unknown.

Check failure on line 8 in src/System Application/Test/EntityText/src/MktTextRedTeamAIT.Codeunit.al

GitHub Actions / Build System Application Tests (Clean) / System Application Tests (Clean)

AL0791 The namespace 'AITestToolkit' is unknown.
using System.Text;

codeunit 134641 "Mkt Text RedTeam BCCT"
codeunit 134641 "Mkt Text RedTeam AIT"
{
Subtype = Test;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if TestPermissions needs to be set to disabled.